feat: View Action for Speaker #5390

divyamtayal · 2020-10-26T19:59:01Z

Fixes #4559

Short description of what this resolves:

View Action was transiting the page to editing the speaker info, so the issue is resolved.

Changes proposed in this pull request:

Since there is no view page for speakers, so view page is being created.
The route to which view button was transiting was wrong, so fixed it and now transiting it to view speaker page.
Improved code for Cell Buttons for speaker.

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

Before

View action button was taking to Edit page.

After

Now View Action is taking to new view speaker page

on clicking the speaker

vercel · 2020-10-26T19:59:07Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/ppfrvafg7
✅ Preview: https://open-event-frontend-git-view-action-4559.eventyay.now.sh

app/controllers/events/view/speakers/list.js

lgtm-com · 2020-10-26T20:06:56Z

This pull request introduces 1 alert when merging c43953e into 54059ca - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

lgtm-com · 2020-10-26T20:25:47Z

This pull request introduces 1 alert when merging 630c3b0 into 54059ca - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

codecov · 2020-10-27T11:34:24Z

Codecov Report

Merging #5390 into development will increase coverage by 0.01%.
The diff coverage is 33.33%.

@@               Coverage Diff               @@
##           development    #5390      +/-   ##
===============================================
+ Coverage        23.29%   23.30%   +0.01%     
===============================================
  Files              489      491       +2     
  Lines             5122     5127       +5     
  Branches            37       37              
===============================================
+ Hits              1193     1195       +2     
- Misses            3924     3927       +3     
  Partials             5        5

Impacted Files	Coverage Δ
app/controllers/events/view/speakers/list.js	`0.00% <0.00%> (ø)`
app/controllers/public/speaker/view.js	`0.00% <0.00%> (ø)`
app/routes/public/speaker/view.js	`0.00% <0.00%> (ø)`
app/router.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e019e7e...52188a9. Read the comment docs.

divyamtayal · 2020-10-27T11:41:55Z

@iamareebjamal Please do let me know to make any changes further more?

app/templates/components/ui-table/cell/events/view/speakers/cell-buttons.hbs

divyamtayal · 2020-10-27T14:42:34Z

@iamareebjamal Actually we can revert this back to

<div class="hidden ui divider"></div>

and it will work absolutely fine.
The reason why I did it is that in session file the way of doing the same things is like this so just bcz of similar code I though it would be better but the other way will work fine.

And talking about why i removed

<LinkTo/>

This is because LinkTo was taking to specified defined page and inside LinkTo an action is used which also transit the page to respected pages so there was shifting of pages from one to other only on clicking on button once.

This is session file

{{this.record}}
<br><br>
<div class="ui horizontal compact basic buttons">
  <UiPopup @content={{t "View Session"}} @class="ui icon button" @click={{action this.props.actions.viewSession this.extraRecords.id this.extraRecords.event.id}} @position="left center">
    <i class="unhide icon"></i>		
  </UiPopup>
  {{#if (not this.extraRecords.isLocked)}}
    <UiPopup @content={{t "Edit Session"}} @class="ui icon button" @click={{action this.props.actions.editSession this.extraRecords.id this.extraRecords.event.id}} @position="left center">
      <i class="edit icon"></i>
    </UiPopup>
  {{/if}}
  <UiPopup @content={{t "Delete Session"}} @click={{action (confirm (t "Are you sure you would like to delete this Session?") (action this.props.actions.deleteSession this.extraRecords.id))}} @class="ui icon button" @position="left center">
    <i class="trash icon"></i>
  </UiPopup>
</div>

app/controllers/events/view/speakers/list.js

app/templates/components/ui-table/cell/events/view/speakers/cell-buttons.hbs

app/controllers/events/view/speakers/list.js

app/templates/components/ui-table/cell/events/view/speakers/cell-buttons.hbs

app/templates/public/speaker/view.hbs

niranjan94 · 2020-10-28T14:18:33Z

Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/controllers/public/speaker/view.js  3
- app/controllers/events/view/speakers/list.js  1
- tests/unit/routes/public/speaker/view-test.js  1

See the complete overview on Codacy

divyamtayal · 2020-10-28T14:26:58Z

app/controllers/events/view/speakers/list.js

@@ -15,7 +15,7 @@ export default class extends Controller.extend(EmberTableControllerMixin) {
      {
        name            : 'Name',
        valuePath       : 'name',
-        extraValuePaths : ['id', 'event'],
+        extraValuePaths : ['id'],


But this won't work as I said this.extraRecords is not complete speaker object, it has prop of speaker object that are defined in extraValuePaths.

@iamareebjamal its not working with this change, please see to it.

OK, please send a PR with this change

OK and specify same issue #4559 with it or should I create new issue and then do it?

Please see PR #5405

Co-authored-by: Areeb Jamal <jamal.areeb@gmail.com>

Fixed View Action

9bc6bf2

vercel bot deployed to Preview October 26, 2020 19:59 View deployment

Fixed Speaker name

c43953e

vercel bot deployed to Preview October 26, 2020 20:03 View deployment

iamareebjamal reviewed Oct 26, 2020

View reviewed changes

app/controllers/events/view/speakers/list.js Outdated Show resolved Hide resolved

Adding Auth to View Page

630c3b0

vercel bot deployed to Preview October 26, 2020 20:20 View deployment

Event_id from Speaker Object

9d483a4

vercel bot deployed to Preview October 27, 2020 11:10 View deployment

Improved Code

26192bc

vercel bot deployed to Preview October 27, 2020 11:17 View deployment

Improved Code-1

083a248

vercel bot deployed to Preview October 27, 2020 11:21 View deployment

Improved Code-2

16a76ad

vercel bot deployed to Preview October 27, 2020 11:30 View deployment

iamareebjamal reviewed Oct 27, 2020

View reviewed changes

app/templates/components/ui-table/cell/events/view/speakers/cell-buttons.hbs Show resolved Hide resolved

iamareebjamal reviewed Oct 27, 2020

View reviewed changes

app/controllers/events/view/speakers/list.js Outdated Show resolved Hide resolved

Event_id from Speaker Object-1

106bb7b

vercel bot deployed to Preview October 28, 2020 02:06 View deployment

Event_id from Speaker Object-2

356a27c

vercel bot deployed to Preview October 28, 2020 02:10 View deployment

iamareebjamal reviewed Oct 28, 2020

View reviewed changes

app/templates/components/ui-table/cell/events/view/speakers/cell-buttons.hbs Outdated Show resolved Hide resolved

Event_id from Speaker Object-3

c295b8d

vercel bot deployed to Preview October 28, 2020 14:03 View deployment

iamareebjamal previously approved these changes Oct 28, 2020

View reviewed changes

iamareebjamal changed the title ~~Fixed View Action for Speaker~~ feat: View Action for Speaker Oct 28, 2020

auto-label bot added the feature label Oct 28, 2020

Merge branch 'development' into view-action-4559

f714e7e

vercel bot deployed to Preview October 28, 2020 14:06 View deployment

iamareebjamal reviewed Oct 28, 2020

View reviewed changes

app/controllers/events/view/speakers/list.js Outdated Show resolved Hide resolved

iamareebjamal reviewed Oct 28, 2020

View reviewed changes

app/controllers/events/view/speakers/list.js Outdated Show resolved Hide resolved

iamareebjamal reviewed Oct 28, 2020

View reviewed changes

app/templates/components/ui-table/cell/events/view/speakers/cell-buttons.hbs Outdated Show resolved Hide resolved

iamareebjamal reviewed Oct 28, 2020

View reviewed changes

app/templates/public/speaker/view.hbs Outdated Show resolved Hide resolved

Apply suggestions from code review

52188a9

iamareebjamal dismissed their stale review via 52188a9 October 28, 2020 14:12

vercel bot deployed to Preview October 28, 2020 14:12 View deployment

divyamtayal commented Oct 28, 2020

View reviewed changes

iamareebjamal merged commit dabb7af into fossasia:development Oct 28, 2020

divyamtayal deleted the view-action-4559 branch October 28, 2020 16:31

sansyrox pushed a commit to sansyrox/open-event-frontend that referenced this pull request Nov 9, 2020

feat: View Action for Speaker (fossasia#5390)

1daedf2

Co-authored-by: Areeb Jamal <jamal.areeb@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: View Action for Speaker #5390

feat: View Action for Speaker #5390

divyamtayal commented Oct 26, 2020 •

edited

Loading

vercel bot commented Oct 26, 2020 •

edited

Loading

lgtm-com bot commented Oct 26, 2020

lgtm-com bot commented Oct 26, 2020

codecov bot commented Oct 27, 2020 •

edited

Loading

divyamtayal commented Oct 27, 2020 •

edited

Loading

divyamtayal commented Oct 27, 2020 •

edited

Loading

niranjan94 commented Oct 28, 2020

divyamtayal Oct 28, 2020

divyamtayal Oct 28, 2020

iamareebjamal Oct 28, 2020

divyamtayal Oct 28, 2020 •

edited

Loading

iamareebjamal Oct 28, 2020

divyamtayal Oct 28, 2020

feat: View Action for Speaker #5390

feat: View Action for Speaker #5390

Conversation

divyamtayal commented Oct 26, 2020 • edited Loading

Short description of what this resolves:

Changes proposed in this pull request:

Checklist

Before

After

vercel bot commented Oct 26, 2020 • edited Loading

lgtm-com bot commented Oct 26, 2020

lgtm-com bot commented Oct 26, 2020

codecov bot commented Oct 27, 2020 • edited Loading

Codecov Report

divyamtayal commented Oct 27, 2020 • edited Loading

divyamtayal commented Oct 27, 2020 • edited Loading

niranjan94 commented Oct 28, 2020

divyamtayal Oct 28, 2020

Choose a reason for hiding this comment

divyamtayal Oct 28, 2020

Choose a reason for hiding this comment

iamareebjamal Oct 28, 2020

Choose a reason for hiding this comment

divyamtayal Oct 28, 2020 • edited Loading

Choose a reason for hiding this comment

iamareebjamal Oct 28, 2020

Choose a reason for hiding this comment

divyamtayal Oct 28, 2020

Choose a reason for hiding this comment

divyamtayal commented Oct 26, 2020 •

edited

Loading

vercel bot commented Oct 26, 2020 •

edited

Loading

codecov bot commented Oct 27, 2020 •

edited

Loading

divyamtayal commented Oct 27, 2020 •

edited

Loading

divyamtayal commented Oct 27, 2020 •

edited

Loading

divyamtayal Oct 28, 2020 •

edited

Loading