-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Show full name and remove date and time in Organizer Orders Overview Page #5673
fix: Show full name and remove date and time in Organizer Orders Overview Page #5673
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/ez4w6zo2p |
{{t 'by'}} {{if this.extraRecords.user.firstName this.extraRecords.user.firstName (t 'Name not provided')}} | ||
{{t 'by'}} | ||
{{#if this.extraRecords.user.firstName}} | ||
{{this.extraRecords.user.firstName}} {{if this.extraRecords.user.lastName this.extraRecords.user.lastName}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have a fullName computed property in user
Codecov Report
@@ Coverage Diff @@
## development #5673 +/- ##
============================================
Coverage 23.72% 23.72%
============================================
Files 498 498
Lines 5277 5277
Branches 47 47
============================================
Hits 1252 1252
Misses 4017 4017
Partials 8 8
Continue to review full report at Codecov.
|
Now that I look more into detail of orders and attendees I think we need additional changes (which contradict the initial issue a bit). Are you up for it? Would be great if you could also do the following changes:
|
e93ef17
to
06db45f
Compare
Fixes #5668
Changes proposed in this pull request:
Checklist
development
branch.screenshots