Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show full name and remove date and time in Organizer Orders Overview Page #5673

Merged

Conversation

sachinchauhan2889
Copy link
Contributor

Fixes #5668

Changes proposed in this pull request:

  • In the first column show full name.
  • take out the date and time in the first column (we already have it in the second column)

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

screenshots

l1

@vercel
Copy link

vercel bot commented Nov 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/ez4w6zo2p
✅ Preview: https://open-event-frontend-git-order-table-enhance.eventyay.vercel.app

{{t 'by'}} {{if this.extraRecords.user.firstName this.extraRecords.user.firstName (t 'Name not provided')}}
{{t 'by'}}
{{#if this.extraRecords.user.firstName}}
{{this.extraRecords.user.firstName}} {{if this.extraRecords.user.lastName this.extraRecords.user.lastName}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have a fullName computed property in user

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #5673 (06db45f) into development (5d34f21) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5673   +/-   ##
============================================
  Coverage        23.72%   23.72%           
============================================
  Files              498      498           
  Lines             5277     5277           
  Branches            47       47           
============================================
  Hits              1252     1252           
  Misses            4017     4017           
  Partials             8        8           
Impacted Files Coverage Δ
app/controllers/events/view/tickets/orders/list.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d34f21...06db45f. Read the comment docs.

@mariobehling
Copy link
Member

Now that I look more into detail of orders and attendees I think we need additional changes (which contradict the initial issue a bit). Are you up for it? Would be great if you could also do the following changes:

  • add two columns for First Name and Last Name
  • Take out "by Name" from "Order" column
  • change "Total Amount" to right-align numbers
  • Change "Date And Time" to "Date and Time"

@sachinchauhan2889
Copy link
Contributor Author

kap2

@iamareebjamal iamareebjamal changed the title fix: Show full name and remove date and time form order cell from orders table in Organizer Orders Overview Page fix: Show full name and remove date and time in Organizer Orders Overview Page Nov 18, 2020
@iamareebjamal iamareebjamal merged commit 3c8f599 into fossasia:development Nov 18, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the order-table-enhance branch November 18, 2020 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organizer Orders Overview Page showing Given Name instead of Full Name, Also shows date 2 times on table
3 participants