Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the CSS cursor property on Login and Register Page #7367

Closed
wants to merge 1 commit into from

Conversation

Priyaraj17
Copy link

Fixes #7330

Short description of what this resolves:

Login and Register Text Interface have a different cursor property while hovering on it. They should have the same CSS cursor property.

Changes proposed in this pull request:

I have updated the property to fix the bug.

Screenshots / Demo Video:

01.06.2021_12.49.47_REC.mp4

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Jun 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/AdpeQzkzc426MEcoD88nJc5wJHWk
✅ Preview: https://open-event-frontend-git-fork-priyaraj17-user-interface-eventyay.vercel.app

Copy link
Member

@iamdevvalecha iamdevvalecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #7367 (9f11cd9) into development (11420db) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7367      +/-   ##
===============================================
- Coverage        20.88%   20.81%   -0.08%     
===============================================
  Files              574      574              
  Lines             6531     6553      +22     
  Branches           149      149              
===============================================
  Hits              1364     1364              
- Misses            5140     5162      +22     
  Partials            27       27              
Impacted Files Coverage Δ
app/routes/admin/sessions/list.js 0.00% <0.00%> (ø)
app/controllers/admin/sessions/list.js 0.00% <0.00%> (ø)
app/components/events/view/publish-bar.ts 15.62% <0.00%> (ø)
app/controllers/public/cfs/view-session.js 0.00% <0.00%> (ø)
app/controllers/public/cfs/view-speaker.js 0.00% <0.00%> (ø)
app/controllers/events/view/sessions/list.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11420db...9f11cd9. Read the comment docs.

Copy link

@rajkumar100 rajkumar100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary issue and pr plz work on that issues which is created by Mentors.

@@ -55,7 +55,7 @@ $spacer-heights: 50 100 200 300 400 500 600 700 800 900;

[data-ember-action] {
&:not(:disabled) {
cursor: pointer;
cursor: text;
Copy link
Member

@MeghalBisht MeghalBisht Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong.
The previous css property was a workaround that makes an HTML element tied with an action helper clickable which is initially not clickable.
For example: In various places we have a div tied to an action helper. Now, after this change, that div will no longer be clickable.
This is a very low priority bug. We cannot block other places in order to solve this. I am closing it therefore.

@MeghalBisht MeghalBisht closed this Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication Text Interface does not matches
4 participants