-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the CSS cursor property on Login and Register Page #7367
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/AdpeQzkzc426MEcoD88nJc5wJHWk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Codecov Report
@@ Coverage Diff @@
## development #7367 +/- ##
===============================================
- Coverage 20.88% 20.81% -0.08%
===============================================
Files 574 574
Lines 6531 6553 +22
Branches 149 149
===============================================
Hits 1364 1364
- Misses 5140 5162 +22
Partials 27 27
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary issue and pr plz work on that issues which is created by Mentors.
@@ -55,7 +55,7 @@ $spacer-heights: 50 100 200 300 400 500 600 700 800 900; | |||
|
|||
[data-ember-action] { | |||
&:not(:disabled) { | |||
cursor: pointer; | |||
cursor: text; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong.
The previous css property was a workaround that makes an HTML element tied with an action
helper clickable which is initially not clickable.
For example: In various places we have a div
tied to an action
helper. Now, after this change, that div
will no longer be clickable.
This is a very low priority bug. We cannot block other places in order to solve this. I am closing it therefore.
Fixes #7330
Short description of what this resolves:
Login and Register Text Interface have a different cursor property while hovering on it. They should have the same CSS cursor property.
Changes proposed in this pull request:
I have updated the property to fix the bug.
Screenshots / Demo Video:
01.06.2021_12.49.47_REC.mp4
Checklist
development
branch.