Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set colour scheme for SwipeRefreshLayout in Speakers Call fragment #1461

Merged
merged 2 commits into from
Jan 24, 2019
Merged

fix: Set colour scheme for SwipeRefreshLayout in Speakers Call fragment #1461

merged 2 commits into from
Jan 24, 2019

Conversation

ShridharGoel
Copy link
Member

Fixes #1460

Checklist:

  • I have checked for PMD and check-style issues
  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.

Changes:

Colour scheme has been set for SwipeRefreshLayout in Speakers Call fragment. Now, the refresh icon would have the same colour as in the other fragments.

@ShridharGoel ShridharGoel changed the title fix: Set colour scheme for SwipeRefreshLayout in Speakers Call fix: Set colour scheme for SwipeRefreshLayout in Speakers Call fragment Jan 24, 2019
@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #1461 into development will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                @@
##             development    #1461      +/-   ##
=================================================
- Coverage          24.25%   24.25%   -0.01%     
  Complexity           757      757              
=================================================
  Files                237      237              
  Lines               8737     8738       +1     
  Branches             356      356              
=================================================
  Hits                2119     2119              
- Misses              6534     6535       +1     
  Partials              84       84
Impacted Files Coverage Δ Complexity Δ
...core/speakerscall/detail/SpeakersCallFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48b51b2...51b1fca. Read the comment docs.

Copy link
Member

@GOVINDDIXIT GOVINDDIXIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mergeable is failing as PR title contain "wip"

@iamareebjamal iamareebjamal merged commit cfd67bc into fossasia:development Jan 24, 2019
@ShridharGoel ShridharGoel deleted the issue1460 branch January 25, 2019 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants