Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Validate base URL in auth fragments #1491

Merged
merged 8 commits into from
Mar 31, 2019
Merged

fix: Validate base URL in auth fragments #1491

merged 8 commits into from
Mar 31, 2019

Conversation

ShridharGoel
Copy link
Member

@ShridharGoel ShridharGoel commented Jan 31, 2019

Fixes #1490

Checklist:

  • I have checked for PMD and check-style issues
  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.

Changes:

Now, base URL entered by the user would be validated and error would be shown if it's found to be invalid.

GIF for the change:

ezgif com-video-to-gif 33

@codecov
Copy link

codecov bot commented Jan 31, 2019

Codecov Report

Merging #1491 into development will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                @@
##             development    #1491      +/-   ##
=================================================
- Coverage          24.82%   24.78%   -0.05%     
  Complexity           800      800              
=================================================
  Files                238      238              
  Lines               8955     8970      +15     
  Branches             369      374       +5     
=================================================
  Hits                2223     2223              
- Misses              6648     6663      +15     
  Partials              84       84
Impacted Files Coverage Δ Complexity Δ
...ganizer/core/auth/reset/ResetPasswordFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ore/organizer/password/ChangePasswordFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...yay/organizer/core/auth/signup/SignUpFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ntyay/organizer/core/auth/start/StartFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ntyay/organizer/core/auth/login/LoginFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 534538d...e687a4b. Read the comment docs.

@ShridharGoel ShridharGoel changed the title fix: Validate base URL in auth fragments [WIP] fix: Validate base URL in auth fragments Jan 31, 2019
@ci-reporter
Copy link

ci-reporter bot commented Feb 1, 2019

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 11e12c5. Here's the output:

Run Tests
registerResGeneratingTask is deprecated, use registerGeneratedResFolders(FileCollection)

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

1 similar comment
@ci-reporter
Copy link

ci-reporter bot commented Feb 1, 2019

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 11e12c5. Here's the output:

Run Tests
registerResGeneratingTask is deprecated, use registerGeneratedResFolders(FileCollection)

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

@ShridharGoel ShridharGoel changed the title [WIP] fix: Validate base URL in auth fragments fix: Validate base URL in auth fragments Feb 1, 2019
@iamareebjamal
Copy link
Member

Too complex change

@ShridharGoel
Copy link
Member Author

@iamareebjamal I think it's looking complex because the change had to be implemented in all the fragments which have the functionality of changing the base URL. I think there's no simpler way to do it, is there one? Validating in XML wouldn't work since it validates the view even when it's hidden.

@fossasia fossasia deleted a comment Feb 1, 2019
@fossasia fossasia deleted a comment Feb 1, 2019
@fossasia fossasia deleted a comment Feb 1, 2019
@fossasia fossasia deleted a comment Feb 1, 2019
@fossasia fossasia deleted a comment Feb 1, 2019
@fossasia fossasia deleted a comment Feb 1, 2019
@ShridharGoel
Copy link
Member Author

@iamareebjamal Please review this

@iamareebjamal iamareebjamal merged commit cdb9944 into fossasia:development Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants