-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Validate base URL in auth fragments #1491
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1491 +/- ##
=================================================
- Coverage 24.82% 24.78% -0.05%
Complexity 800 800
=================================================
Files 238 238
Lines 8955 8970 +15
Branches 369 374 +5
=================================================
Hits 2223 2223
- Misses 6648 6663 +15
Partials 84 84
Continue to review full report at Codecov.
|
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 11e12c5. Here's the output:
|
1 similar comment
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 11e12c5. Here's the output:
|
Too complex change |
@iamareebjamal I think it's looking complex because the change had to be implemented in all the fragments which have the functionality of changing the base URL. I think there's no simpler way to do it, is there one? Validating in XML wouldn't work since it validates the view even when it's hidden. |
@iamareebjamal Please review this |
Fixes #1490
Checklist:
Changes:
Now, base URL entered by the user would be validated and error would be shown if it's found to be invalid.
GIF for the change: