Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Migrate ChartPresenter to ViewModel #1664

Merged
merged 7 commits into from
Jun 12, 2019
Merged

chore: Migrate ChartPresenter to ViewModel #1664

merged 7 commits into from
Jun 12, 2019

Conversation

ShridharGoel
Copy link
Member

Fixes #1663

Checklist:

  • I have checked for PMD and check-style issues
  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.

Changes:

Converted ChartPresenter to ViewModel.

@auto-label auto-label bot added the chore label May 25, 2019
@iamareebjamal iamareebjamal merged commit d91bf54 into fossasia:development Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liveHarshit liveHarshit liveHarshit approved these changes

@mooocer mooocer Awaiting requested review from mooocer

@iamareebjamal iamareebjamal Awaiting requested review from iamareebjamal

@abishekvashok abishekvashok Awaiting requested review from abishekvashok

@anhanh11001 anhanh11001 Awaiting requested review from anhanh11001

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert ChartPresenter to ViewModel
4 participants
@ShridharGoel @liveHarshit @iamareebjamal @mariobehling