Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Display user friendly error message for wrong credentials #1905

Merged
merged 3 commits into from
Aug 18, 2019
Merged

chore: Display user friendly error message for wrong credentials #1905

merged 3 commits into from
Aug 18, 2019

Conversation

ShridharGoel
Copy link
Member

Fixes #1900

@auto-label auto-label bot added the chore label Aug 18, 2019
iamareebjamal
iamareebjamal requested changes Aug 18, 2019
View reviewed changes
Copy link
Member

@iamareebjamal iamareebjamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check response code

@ShridharGoel
Copy link
Member Author

Updated.

@ci-reporter
Copy link

ci-reporter bot commented Aug 18, 2019

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of e57a2a3. Here's the output:

Test Coverage

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

1 similar comment
@ci-reporter
Copy link

ci-reporter bot commented Aug 18, 2019

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of e57a2a3. Here's the output:

Test Coverage

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

@iamareebjamal iamareebjamal merged commit c95b98c into fossasia:development Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show a more user friendly message than 401
2 participants
@ShridharGoel @iamareebjamal