Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5339 Create event acc to module values #5340

Merged
merged 6 commits into from
Aug 14, 2018

Conversation

bhaveshAn
Copy link
Member

Fixes #5339 Create event acc to module values

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

Fixes #5339 Create event acc to module values

Changes proposed in this pull request:

CASE 1: Ticketing is not enabled in system
screenshot from 2018-08-13 01-00-36

CASE 2: Payments is not enabled in system
screenshot from 2018-08-13 01-01-44

CASE 3: Donations is not enabled in system
screenshot from 2018-08-13 01-03-50

@codecov
Copy link

codecov bot commented Aug 13, 2018

Codecov Report

Merging #5340 into development will decrease coverage by 0.06%.
The diff coverage is 27.27%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5340      +/-   ##
===============================================
- Coverage        62.86%   62.79%   -0.07%     
===============================================
  Files              261      261              
  Lines            12615    12635      +20     
===============================================
+ Hits              7930     7934       +4     
- Misses            4685     4701      +16
Impacted Files Coverage Δ
app/models/event.py 81.66% <100%> (+0.15%) ⬆️
app/api/schema/events.py 89.92% <100%> (+0.07%) ⬆️
app/api/events.py 24.72% <5.88%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6629139...8d49f5c. Read the comment docs.

@fossasia fossasia deleted a comment Aug 13, 2018
@fossasia fossasia deleted a comment Aug 13, 2018
@fossasia fossasia deleted a comment Aug 13, 2018
@fossasia fossasia deleted a comment Aug 13, 2018
@fossasia fossasia deleted a comment Aug 13, 2018
@fossasia fossasia deleted a comment Aug 13, 2018
@fossasia fossasia deleted a comment Aug 14, 2018
@fossasia fossasia deleted a comment Aug 14, 2018
@fossasia fossasia deleted a comment Aug 14, 2018
@bhaveshAn
Copy link
Member Author

@mayank8318 @Kreijstal @schedutron Please review

@fossasia fossasia deleted a comment Aug 14, 2018
@fossasia fossasia deleted a comment Aug 14, 2018
@bhaveshAn
Copy link
Member Author

@srv-twry This can be merged !

@dr0pdb dr0pdb merged commit 230d07a into fossasia:development Aug 14, 2018
@bhaveshAn bhaveshAn deleted the module-bug branch August 14, 2018 18:14
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Jan 30, 2019
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Event acc to module values
4 participants