Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make app name appear only when logo is not there #8649

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

progmatic-99
Copy link
Contributor

@progmatic-99 progmatic-99 commented Apr 13, 2022

Fixes #8642

Screenshot 2022-04-13 at 16-21-46 test-free-reg-Tickets-812a9180-41dc-4299-b89e-c2a0e06ff62e pdf

@mariobehling For the translation part, user has to change the user locale setting in their account to their desired language.
As for other parts, I have chosen hindi as a locale, for which translation is not present. That's why it's in english.

@auto-label auto-label bot added the fix label Apr 13, 2022
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #8649 (7dc8a75) into development (461273f) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development    #8649   +/-   ##
============================================
  Coverage        65.58%   65.58%           
============================================
  Files              306      306           
  Lines            15999    15999           
============================================
  Hits             10493    10493           
  Misses            5506     5506           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 461273f...7dc8a75. Read the comment docs.

@mariobehling mariobehling merged commit ee8b59c into fossasia:development Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registration PDF is not fully translatable
2 participants