feat: feature to see altitude from pressure added in Barometer #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (pressure <= 0.0) { | ||
| return 0; | ||
| } else { | ||
| return (float) (44330 * (1 - Math.pow(pressure, 1.0 / 5.255))); |
There was a problem hiding this comment.
Where did you get these values and equations? Better mention reference as a comment
There was a problem hiding this comment.
https://cdn-shop.adafruit.com/datasheets/BST-BMP180-DS000-09.pdf check section 3.6 on page 16
CloudyPadmal
changed the title
CloudyPadmal
requested changes
Aug 13, 2019
neel1998
force-pushed
the
altitude_meter
branch
from
30e4a67
to
049ed3a
Compare
CloudyPadmal
requested changes
Aug 13, 2019
neel1998
force-pushed
the
altitude_meter
branch
from
049ed3a
to
084adba
Compare
|
@CloudyPadmal please review |
CloudyPadmal
approved these changes
Aug 15, 2019
CloudyPadmal
added
the
Status: Review Required
cweitat
approved these changes
Aug 15, 2019
CloudyPadmal
removed
the
Status: Review Required
makoteq
pushed a commit
to makoteq/pslab-android
that referenced
this pull request
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1598
Changes: feature to see altitude from pressure added in Barometer
Screenshot/s for the changes:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
altitude.zip