Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: side navbar rearranged #1942

Merged
merged 1 commit into from
Aug 17, 2019
Merged

fix: side navbar rearranged #1942

merged 1 commit into from
Aug 17, 2019

Conversation

neel1998
Copy link
Member

@neel1998 neel1998 commented Aug 15, 2019 •
edited
Loading

Fixes #1939

Changes: side navbar rearranged

Screenshot/s for the changes:

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:

sidenav.zip

@CloudyPadmal
Copy link
Collaborator

I think it would be better to add which flavor the app is to About Us screen. https://riptutorial.com/android-gradle/example/11474/flavor-constants-and-resources-in-build-gradle would help.

@CloudyPadmal CloudyPadmal added the Fix Solution to an existing issue in app label Aug 15, 2019
CloudyPadmal
CloudyPadmal requested changes Aug 16, 2019
View reviewed changes
app/build.gradle Outdated Show resolved Hide resolved
app/build.gradle Outdated Show resolved Hide resolved
app/src/main/java/io/pslab/activity/MainActivity.java Outdated Show resolved Hide resolved
@mariobehling
Copy link
Member

Please move "Feedback and Bugs" above Version info.

@mariobehling
Copy link
Member

Use International English!

  • No space before ":".
  • Write names correctly, e.g. Play store

@neel1998
Copy link
Member Author

@mariobehling @CloudyPadmal please review. I have made requested changes

@neel1998
Copy link
Member Author

@CloudyPadmal please merge.

@cweitat cweitat merged commit eb92c34 into fossasia:development Aug 17, 2019
@neel1998 neel1998 deleted the sidenav_fix branch August 27, 2019 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweitat cweitat cweitat approved these changes

@CloudyPadmal CloudyPadmal CloudyPadmal approved these changes

@mariobehling mariobehling Awaiting requested review from mariobehling

Assignees

@neel1998 neel1998

Labels
Fix Solution to an existing issue in app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navigation Drawer: Change sorting, move items, fix design
4 participants
@neel1998 @CloudyPadmal @mariobehling @cweitat