Added fixes and installation documentation #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Sid911
commented
Jan 10, 2020
•
Sid911
commented
- Please check if the PR fulfills these requirements
- The commit message follows our guidelines
- Docs have been added / updated (for bug fixes / features)
- What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
- Bug fix
- Feature implementation
- Doc updates
- What changes have you introduced?
- fixes Insufficient Doc for Desktop version of Pslab #69
- Added installation documentation for all three platforms
- fixed the erros in documentation when this file was changed from rst to md
- Preview / Steps to verify your work:
- Go to https://github.com/sid911/pslab-documentation
- Click on Desktop.md file to preview it
|
This is for developers. Isn't there a way to install production build? 🤔🤔 |
|
yeah there is... its in install branch but that never gets builds because build system isn't working atm |
|
@fcartegnie @hongquan @mariobehling can this be reviewed 😇 thanks |
kumuditha-udayanga
approved these changes
Jan 11, 2020
fcartegnie
requested changes
Jan 11, 2020
|
@fcartegnie Done :) |
fcartegnie
reviewed
Jan 11, 2020
|
@fcartegnie fixed typo and added formatting, if that meant this |
fcartegnie
approved these changes
Jan 11, 2020
|
@cweitat please review and merge 😀 |
cweitat
requested changes
Jan 12, 2020
cweitat
requested changes
Jan 12, 2020
|
@cweitat I think that's it.. for typos that I could spot 😅.. I just copy pasted that to word 😂 |
cweitat
requested changes
Jan 12, 2020
|
@cweitat that section is already made.. just the link wasn't correct as it was changed from .rst to .md,I changed just that part :) I guess you didn't expand and just saw the changes section 😅 and didn't see the preview
|
kumuditha-udayanga
pushed a commit
to kumuditha-udayanga/pslab-documentation
that referenced
this pull request
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.