Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor UART #202

Merged
merged 4 commits into from
Aug 19, 2021
Merged

Refactor UART #202

merged 4 commits into from
Aug 19, 2021

Conversation

nkpro2000sr
Copy link
Member

@nkpro2000sr nkpro2000sr commented Aug 17, 2021 •
edited
Loading

  • Refactor UART
  • Add tests

@nkpro2000sr
Copy link
Member Author

@bessman
All changes are made 👍 and ready to review.

bessman
bessman approved these changes Aug 19, 2021
View reviewed changes
Copy link
Collaborator

@bessman bessman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. The E402 violation in __init__.py is not ideal but I see it is necessary to avoid circular import. Since it's temporary (until we drop support for python3.8 in a few years), it's acceptable.

@bessman bessman merged commit 6720530 into fossasia:development Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bessman bessman bessman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nkpro2000sr @bessman