Add functionality to enable/disable captcha #2796

[fragm3]

Fixes #2796

Changes:

• Add functionality to enable/disable captcha
• Fix API key destructuring

Demo Link: https://pr-2810-fossasia-susi-web-chat.surge.sh

Screenshots of the change:

[akshatnitd]

Keep a separate value for client side captcha. It would give us more control.

Let there be 2 -
isCaptchaEnabled - For server
isClientCaptchaEnabled - For client

[fragm3]

@akshatnitd for the captcha to verify on the server-side, it should always work on the client side, how else will we verify user captcha response.

[akshatnitd]

Earlier, we didn't have server side captcha validation. But, it can work, right.
What if, we don't want server side captcha revalidation, only client side. We can't control if we have only 1 flag.

[fragm3]

@akshatnitd that would be quite redundant 😿 , I'll do it if you say so

[akshatnitd]

@fragm3 I ll give you a use-case. Let me know, if it makes sense.

When the server side captcha was implemented, the Android login/signup started to fail. Also, there might be instances, when other clients might not have implemented captcha, and failed requests may happen.

These combinations are required for us -
Server - true; Client - true //best-case
Server - false, Client true
Server - false, Client - false //worst-case.

Does this make sense?

[fragm3]

@akshatnitd cross clients implementation makes sense, will do it 😸

[fragm3]

@akshatnitd made the changes.

[akshatnitd]

isClientCaptchaEnabled

[fragm3]

@akshatnitd done

[mariobehling]

Sorry, but I need to revert this. You have not actually solved the issue. You solved something else that is not related to the issue. Not sure, what is your idea here. Please read the issue again.