Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes 2977 - Making the settings page scrollable #2979

Merged
merged 1 commit into from Oct 28, 2019
Merged

Fixes 2977 - Making the settings page scrollable #2979

merged 1 commit into from Oct 28, 2019

Conversation

AuraOfDivinity
Copy link
Contributor

@AuraOfDivinity AuraOfDivinity commented Oct 22, 2019 •
edited

Fixes #2977

Changes:

  1. Changed the overflow property of the root container in settings page from 'hidden' to 'scroll', enabling the page to be scrolled.
  2. Changed the position property of the Timezone styled component from absolute to relative.

Demo Link: http://enchanting-run.surge.sh/

Screenshots of the change:

ScrollableSettings

@mariobehling mariobehling merged commit fd0d3c2 into fossasia:master Oct 28, 2019
pulkit1joshi pushed a commit to pulkit1joshi/susi.ai that referenced this pull request Jan 20, 2020
@AuraOfDivinity @mariobehling
Fixes 2977 - Making the settings page scrollable (fossasia#2979)
e00f42a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariobehling mariobehling mariobehling approved these changes

@plxity plxity plxity approved these changes

@samagragupta samagragupta samagragupta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to view the entire settings page in mobile view.
4 participants
@AuraOfDivinity @mariobehling @plxity @samagragupta