Close button fix #3021
Closed
Close button fix #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plxity
suggested changes
Nov 6, 2019
AuraOfDivinity
suggested changes
Nov 6, 2019
There was a problem hiding this comment.
Great work @vaibhavmathur13 ! The change looks fine for me. Just a couple of small changes though,
- Remove the yarn.lock file as it's not needed
- Add in the deployment link in your pull request. The link for this specific PR is https://pr-3021-fossasia-susi-web-chat.surge.sh . Your changes are automatically deployed once you make a PR and you only have to add in the PR number to the link. (For example for the pr with the number 3024, the link would be https://pr-3024-fossasia-susi-web-chat.surge.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2947
Changes: Shifted the close button to left so that it doesn't overlap with scroll bar.
Screenshots of the change: Before:
After: