Fixed issue #3343: Scroll bottom button misbehaviour #3422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
reviewed
Feb 4, 2020
| @@ -10,7 +10,7 @@ const ScrollTopFab = styled(Fab)` | |||
| top: ${props => props.height - 95 + 'px'}; | |||
| right: ${props => (props.width < 1100 ? '70px' : '100px')}; | |||
| margin: 15px; | |||
| z-index: 9000; | |||
| z-index: 2; | |||
There was a problem hiding this comment.
This change in Z-Index is not required I guess.
There was a problem hiding this comment.
This is required as the scroll to top button which leads to the top of the webpage conflicts with the chat box input. See here,
There was a problem hiding this comment.
The z-index puts the chat modal over the button to resolve this issue.
maze-runnar
suggested changes
Feb 5, 2020
| scrollValues.scrollHeight - Math.ceil(scrollValues.scrollTop) === | ||
| scrollValues.clientHeight | ||
| !(showScrollBottom && showScrollTop) && | ||
| scrollValues.clientHeight + scrollValues.scrollTop < |
There was a problem hiding this comment.
add Math.ceil(scrollValues.scrollTop) .
maze-runnar
approved these changes
Feb 5, 2020
snitin315
approved these changes
Feb 6, 2020
pulkit1joshi
approved these changes
Feb 8, 2020
anishagg17
suggested changes
Feb 9, 2020
|
…lay conditions Fixed issue #3343 scroll buttons misbehaving Fixed Issue #3343 scroll buttons misbehaving refactored susi-chatbot.js to ES6 and eliminate the use of jQuery (#3407) Co-authored-by: Akshat Garg <akshatnitd@gmail.com> Made bot wizard stepper linear (#3357) handled check() Co-authored-by: Akshat Garg <akshatnitd@gmail.com> Used class field declarations for javascript (#3419) Co-authored-by: Akshat Garg <akshatnitd@gmail.com> removed blank message (#3416) fixed error in chat with susi (#3440) Used class field declarations for javascript (#3443) Fixed unnecessary scrollbar in settings (#3437) Fixed double scrollbar in settings menu Co-authored-by: Akshat Garg <akshatnitd@gmail.com> Fixed overflow in x-direction (#3424) * overflow in x direction fixed * overflow in x direction fixed Co-authored-by: Akshat Garg <akshatnitd@gmail.com> Sorted the skill feedbacks wrt timestamps (#3433) Co-authored-by: Akshat Garg <akshatnitd@gmail.com> Corrected typo in Projection_Information.md (#3421) Co-authored-by: Akshat Garg <akshatnitd@gmail.com> Checked prettier fails Fixed issue #3343 Scroll button misbehavior
Dilshaad21
reviewed
Feb 12, 2020
Conflicts resolved |
akshatnitd
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3343
Changes:
Demo Link : https://pr-3422-fossasia-susi-web-chat.surge.sh/