Fixed slide show button #3477
Merged
Fixed slide show button #3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulkit1joshi
force-pushed
the
fixingslideshow
branch
from
a1802e6
to
a29379a
Compare
|
@akshatnitd Please review this pull request. |
akshatnitd
approved these changes
Feb 16, 2020
|
Next time onwards, make sure no one else is already working on an issue before moving forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3371
Changes: Previously, the button when clicked on extremes (top/bottom) navigated user to other pages which is not desirable from users perspective. When not visible, any image on slide show should not navigate the user to that link and rather show that image first.
Demo Link:
Screenshots of the change:
Now : -
Before : -
