New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes#412: user can now add background image to message section #415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i can't change the colour of the message pane .can you check that again
@@ -546,7 +565,7 @@ class MessageSection extends Component { | |||
<ul | |||
className='message-list' | |||
ref={(c) => { this.messageList = c; }} | |||
style={{background:pane}}> | |||
style={messageBackgroundStyles}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's have the background-repeat:none
property as well to the styles. @madhavrathi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes which @isuruAb suggested and the one related to background-repeat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are we going to store these settings on server?
@rishiraj824 Please Review. @isuruAb I am able to change image just fine, can you try again with a different image. For ex. try this url https://image.freepik.com/free-vector/abstract-blue-background_1048-1511.jpg |
@uday96 Probably, this will only be a one time use feature because currently, the server is not going to store any file of a user. If I am not wrong the Android Client does it but it happens locally only on the App fossasia/susi_android#504 |
|
@rishiraj824 It all looks good now. Please Review http://susimadhav.surge.sh/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @madhavrathi ! Looks good now!
Fixes issue #412
Changes: Now user can choose background for message section as well.
Demo Link: http://susimadhav.surge.sh/
Screenshots for the change:
@rishiraj824 @uday96 @isuruAb @daminisatya Please Review
Thanks