Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes#412: user can now add background image to message section #415

Merged
merged 2 commits into from Jul 8, 2017

Conversation

madhavrathi
Copy link
Contributor

@madhavrathi madhavrathi commented Jul 7, 2017

Fixes issue #412

Changes: Now user can choose background for message section as well.

Demo Link: http://susimadhav.surge.sh/

Screenshots for the change:

aajkaissuefix
@rishiraj824 @uday96 @isuruAb @daminisatya Please Review
Thanks

Copy link
Member

@isuruAb isuruAb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can't change the colour of the message pane .can you check that again

@@ -546,7 +565,7 @@ class MessageSection extends Component {
<ul
className='message-list'
ref={(c) => { this.messageList = c; }}
style={{background:pane}}>
style={messageBackgroundStyles}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have the background-repeat:none property as well to the styles. @madhavrathi

Copy link
Member

@rishiraj824 rishiraj824 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes which @isuruAb suggested and the one related to background-repeat

Copy link
Contributor

@uday96 uday96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we going to store these settings on server?

@madhavrathi
Copy link
Contributor Author

@rishiraj824 Please Review. @isuruAb I am able to change image just fine, can you try again with a different image. For ex. try this url https://image.freepik.com/free-vector/abstract-blue-background_1048-1511.jpg
Thanks

@rishiraj824
Copy link
Member

@uday96 Probably, this will only be a one time use feature because currently, the server is not going to store any file of a user. If I am not wrong the Android Client does it but it happens locally only on the App fossasia/susi_android#504

@rishiraj824
Copy link
Member

screenshot from 2017-07-08 14 32 47
@madhavrathi What I meant by adding a background-repeat : none was that the background should not repeat itself over the area and cover the whole area. So maybe https://www.w3schools.com/cssref/playit.asp?filename=playcss_background-size&preval=cover
this link can help

@madhavrathi
Copy link
Contributor Author

aajkaissuefix

@rishiraj824 It all looks good now. Please Review http://susimadhav.surge.sh/

Copy link
Member

@rishiraj824 rishiraj824 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @madhavrathi ! Looks good now!

@mariobehling mariobehling merged commit 070ab1b into fossasia:master Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants