fix: modified voice commands #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iamareebjamal Please review this !! |
|
@iamareebjamal Please review this sir!! |
|
Peer reviews |
|
@atm1504 please review this for me!! |
atm1504
reviewed
Apr 14, 2019
| @@ -16,7 +16,7 @@ | |||
| <android.support.v7.widget.RecyclerView | |||
| android:id="@+id/clickableCommands" | |||
| android:layout_width="match_parent" | |||
| android:layout_above="@id/linearLayout" | |||
| android:layout_above="@id/txtChat" | |||
| @@ -13,6 +13,6 @@ | |||
| tools:text="Open WhatsApp" | |||
| android:id="@+id/voiceCommand" | |||
| android:padding="@dimen/padding_moderate" | |||
| android:textSize="@dimen/text_size_large"/> | |||
| android:textSize="@dimen/text_size_medium"/> | |||
There was a problem hiding this comment.
Is just changing the textsize doing the work?
atm1504
approved these changes
Apr 14, 2019
|
@iamareebjamal I have reviewed it. Its okk from my side. |
|
@iamareebjamal Please review this and merge this!! |
iamareebjamal
approved these changes
Apr 14, 2019
|
Can't merge until CircleCI works |
Any idea how to check for ci build failure? |
|
It's not even being triggered. Only happening on your PR apparently |
Yes!! Any idea how to see what the problem is? |
batbrain7
approved these changes
Apr 17, 2019
|
@batbrain7 @arundhati24 as the ci/circleci is failing to trigger can I make a new pr to solve this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2150
Changes:When the user talks, the txtchat is hidden by the voice commands.
Modified it by reducing the size and making it top of txtChat
Screenshots for the change:
