Improved apk upload script #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daminisatya
approved these changes
Jan 1, 2017
|
@daminisatya Please don't merge it currently. We're working on changing APK generation again to make single apk. Multiple APKs are causing compatibility issues. I'll update this PR accordingly. Thanks. 😃 |
betterclever
force-pushed
the
improve-apkgen
branch
2 times, most recently
from
30a9699
to
82b1105
Compare
betterclever
force-pushed
the
improve-apkgen
branch
from
82b1105
to
2d8d21c
Compare
|
@daminisatya @the-dagger I have solved the issue of failing circle builds for pull requests too. Please consider the changes.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue : This fixes the large repo size due to APK branch. After this , only current apk and no old revisions will be kept so repo size will remain under 100mb which is currently ~2GB.