Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Song not played due to wrong communication #413

Closed
hongquan opened this issue Nov 12, 2018 · 1 comment · Fixed by #415
Closed

Song not played due to wrong communication #413

hongquan opened this issue Nov 12, 2018 · 1 comment · Fixed by #415
Labels

Comments

@hongquan
Copy link
Member

Describe the bug

This bug is introduced by #391.
When speaking to susi_linux: "play cheerleader", the main module calls music_server API with "/song/ytd-jGflUbPQfW8" URL. But this URL is not recognized by music_server.

The code

@app.route('/song', methods=['GET'])
def youtube():
vid = request.args.get('vid')

clearly shows that, this module expects URL as /song?vid=jGflUbPQfW8, not /song/ytd-jGflUbPQfW8.

I doubt @stealthanthrax carefully tested his code before making PR.

To Reproduce
Steps to reproduce the behavior:

  1. Stop susi_linux systemd service
  2. Run susi_linux manually (with command python3 -m main)
  3. Run journalctl -fu ss-susi-youtube.service to see this service's log.
  4. Speak "susi play cheerleader" to SUSI (actually, I spoke "susi play soledad", but Google STT somehow misunderstood me).
  5. Look into ss-susi-youtube.service log, I saw this log:
Nov 12 18:38:31 quan-pi-two python3[5814]: 127.0.0.1 - - [12/Nov/2018 18:38:31] "GET /song/ytd-jGflUbPQfW8 HTTP/1.1" 404 -

Expected behavior
susi_linux main module should call correct URL and the song is played.

@sansyrox
Copy link
Member

Fixed here : link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants