Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Tooltip to Susi Launcher Button #1770 #1771

Merged
merged 1 commit into from Jan 21, 2019
Merged

Added Tooltip to Susi Launcher Button #1770 #1771

merged 1 commit into from Jan 21, 2019

Conversation

championpaddler
Copy link
Member

@championpaddler championpaddler commented Jan 2, 2019 •
edited

Fixes #1770

Changes: Added Tooltip to Susi Launcher Button #1770

Surge Deployment Link: https://pr-1771-fossasia-susi-skill-cms.surge.sh

Screenshots for the change:
screenshot from 2019-01-02 19-46-07

@Pipe-Runner
Copy link
Contributor

MUI lib provides tooltips on buttons. See if you can make use of them.

@championpaddler
Copy link
Member Author

MUI lib provides tooltips on buttons. See if you can make use of them.

@AakashMallik Actually, we are using self-made button and the tooltip in material UI requires the use of the material button to add that particular tooltip. So I have to add my own tooltip.

@Pipe-Runner
Copy link
Contributor

@sk9331657 No one is stopping you from using their buttons btw. You are just using your own svg icon, which shall be no problem as far as I know.

@championpaddler
Copy link
Member Author

@sk9331657 No one is stopping you from using their buttons btw. You are just using your own svg icon, which shall be no problem as far as I know.

@AakashMallik I will surely check if that is possible without breaking styling of button.

fragm3
fragm3 suggested changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@fragm3 fragm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are already using tooltip, search for tooltip in package.json and use that

@championpaddler
Copy link
Member Author

@fragm3 Done that way.

@championpaddler
Copy link
Member Author

@Akshat-Jain @akshatnitd Please Review.

@hkedia321
Copy link
Member

Good work @sk9331657. But I am not sure if this is required. Its already quite intuitive to use the launcher.

@Orbiter Orbiter merged commit f98db66 into fossasia:master Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Orbiter Orbiter Orbiter approved these changes

@fragm3 fragm3 fragm3 approved these changes

@Pipe-Runner Pipe-Runner Pipe-Runner approved these changes

@samagragupta samagragupta samagragupta approved these changes

@hkedia321 hkedia321 Awaiting requested review from hkedia321

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@championpaddler @Pipe-Runner @hkedia321 @Orbiter @fragm3 @samagragupta