Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Redux in BrowseSkill Components and other SkillViews #1741 #1776

Closed
wants to merge 2 commits into from
Closed

Integrate Redux in BrowseSkill Components and other SkillViews #1741 #1776

wants to merge 2 commits into from

Conversation

fragm3
Copy link
Contributor

@fragm3 fragm3 commented Jan 4, 2019 •
edited

Fixes #1741

Changes:

  • Integrated redux in browse skill, and other skillView components.
  • The error from issue https://github.com/fossasia/susi_skill_cms/issues/1733, On searching or adding filters and then choosing/applying SUSI category filter, the old filters gets removed, is fixed
  • Created SkillScrollCardList and SkillCard(2 separate components for metric skills)
  • Added tests

Surge Deployment Link: https://pr-1776-1-fossasia-susi-skill-cms.surge.sh

@fragm3
Copy link
Contributor Author

fragm3 commented Jan 4, 2019

@akshatnitd @anshumanv please review

@anshumanv
Copy link
Member

Skills aren't loading it seems, please debug

image

image
Metrics language is undefined, please fix that.

@fragm3 fragm3 mentioned this pull request Jan 5, 2019
Merged
@fragm3 fragm3 closed this Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@fragm3 @anshumanv