Fixing contact form and it's bug (removing require attribute) #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@subhahu123 please provide more information about your PR |
Codecov Report
@@ Coverage Diff @@
## development #1351 +/- ##
===============================================
+ Coverage 54.39% 54.53% +0.13%
===============================================
Files 51 51
Lines 1434 1434
Branches 178 178
===============================================
+ Hits 780 782 +2
+ Misses 547 545 -2
Partials 107 107
Continue to review full report at Codecov.
|
Done @shreyanshdwivedi |
|
@praveenojha33 please review |
subhahu123
changed the title
2 tasks
simsausaurabh
approved these changes
Dec 29, 2018
|
Is it accepting response? |
|
Please don't forget to squash your commits. |
i don't think so |
|
i have only fixed the validation |
|
is this pr is ok or not |
|
Its ok, please squash your commits! |
|
@simsausaurabh done |
rajvaibhavdubey
approved these changes
Jan 2, 2019
bhaveshAn
approved these changes
Jan 3, 2019
subhahu123
added a commit
to subhahu123/susper.com
that referenced
this pull request
Feb 2, 2019
Update contact.component.ts Update contact.component.html
subhahu123
added a commit
to subhahu123/susper.com
that referenced
this pull request
Feb 8, 2019
Update contact.component.ts Update contact.component.html
subhahu123
added a commit
to subhahu123/susper.com
that referenced
this pull request
Mar 1, 2019
The badgeyay's icon on susper.com has been updated. Fixes fossasia#1201 Fixse fossasia#1306: Removed redundant package delarations (fossasia#1307) fixing (fossasia#1351) Update contact.component.ts Update contact.component.html Added sidebar for Privacy page and tests to increase coverage Fixes fossasia#956 content for help section Center Settings and Tools Menu Items Fixing About page css (fossasia#1298) Fixes fossasia#1227 close button to the right (fossasia#1228) Fixes fossasia#1225 adding help in footer (fossasia#1226) Fixing the hovering and visited color of links (fossasia#1293) * Changing color of hovering , Visited link Ignoring the overriden of tags of hover and visited * Changing color Added share link and made styles changes to infobox-share-popup (fossasia#1349) Revert "Center Settings and Tools Menu Items" (fossasia#1231) * Revert "Fixes fossasia#1225 adding help in footer (fossasia#1226)" This reverts commit a727075. * Revert "Fixes fossasia#1227 close button to the right (fossasia#1228)" This reverts commit ae71a6a. * Revert "Center Settings and Tools Menu Items" This reverts commit d20bbcd. "Update the issue template " (fossasia#1219) Fix 1268 - Fix overlapping Help Section with footer (fossasia#1271) * Updated Badgeyay's icon (fossasia#1203) The badgeyay's icon on susper.com has been updated. Fixes fossasia#1201 * "Commit " Fixed overlapping footer, fossasia#1216 (fossasia#1224) add twitter links (fossasia#1236) Fixes fossasia#1242 corrections in crawl job page (fossasia#1243) Refactored Help Component and Added tests for increasing coverage Fix fossasia#1388 : did you mean content is now clickable Refactors Theme Component and added tests for coverage Added YouTube link in the infobox (fossasia#1247) Add Flex Slider to Help Videos (fossasia#1234) Switch Lint Fixes fossasia#1310: Travis issue fixed (fossasia#1207)Added link to map address Fixed Contact Form UI (fossasia#1257) Added/Updated tests cursor chnages to hover Fix 1179 - Add SUSI.AI for Magic Mirror, Yaydoc, Meilix and Phimp.me in Projects section under the menus icon in the navbar add a share button to infobox add a share button to infobox fix indentation add modal add icons fix linting errors fix icons fix travis build errors fix whitespace fix whitespace format HTML add borders improve styles increase padding Fixes fossasia#1322: About component refactored and cleaned up Style and link fixes on the Privacy and Terms page(fossasia#1261) Fixes fossasia#1267: Infobox share modal, styling fixes, redundancies removed changes title according to search depth field only accepts numbers Adding rel="noopener" for fixing cross-link links fix footer Fixed validations in Contact form Made active theme button different from others Fixed linting issue Fixed formatting of code Fixed clear search issue fossasia#1230 Fixed double quotes to single quotes Fixed reference for navbar html Fixed spacing issues in constructor scope Fixed clear search issue fossasia#1230 Fixing the susper logo alignment and its container Fixing alignment for all screen sizes Fixing width of div Update index.component.html Update index.component.css Update index.component.html Update index.component.css Update index.component.css Update index.component.css Update index.component.css Fixed a typo in the contact form New Design of about component The design of the about component has been changed Fixes fossasia#1221 Analytics border lie inside the window (fossasia#1346) Susper logo Addition Update README.md Fixed UI of Advanced Search Page Added sidebar menu on Terms page and tests to increase coverage Fixing not found result page Update results.component.ts Update results.component.ts Update results.component.html Update results.component.html Fixes fossasia#1327: Contact componnet refactored (fossasia#1328) Fixes fossasia#1317: Reducers and Actions cleaned (fossasia#1318)
subhahu123
added a commit
to subhahu123/susper.com
that referenced
this pull request
Mar 1, 2019
…ssasia#1134) Fixes fossasia#1129: Fixed two tabs issue (fossasia#1133) Fixes fossasia#1137: Infobox do not overlap with navbar (fossasia#1138) Addresses fossasia#1136: News Tab show total results (fossasia#1139) Address fossasia#1117: Added URL for logos (fossasia#1140) Fixes fossasia#1143: Aligned upper settings options and made bottom setting options similar to Google (fossasia#1144) Fixes fossasia#1141: Added wikipedia logo and improved design of infobox (fossasia#1142) * Fixes fossasia#1141: Added wikipedia logo and improved design of infobox * Decreased size of logo * Added end of line in svg image Fixes fossasia#1124: Improved Sidebar Top providers and Top authors (fossasia#1145) * Fixes fossasia#1124: Improved Sidebar Top providers and Top authors * Clicking on link hides the lightbox * Made Requested changes Fixes fossasia#1148: Reverted Changes to remove Wikipedia Logo from Infobox (fossasia#1149) Fixes fossasia#1155: Corrected http to https in Readme file (fossasia#1156) Fixes fossasia#1150: Added a link to JSON file of News Organisations (fossasia#1151) * Fixes fossasia#1150: Added a link to JSON file of News Organisations * Changed Message Fixes fossasia#1132: Suggestion box do not move text content. (fossasia#1147) * Fixes fossasia#1132: Suggestion box do not move text content * Fixed overlap in some screen * Fixed unalignment Fixes fossasia#1153: Added RSS and JSON link (fossasia#1154) * Fixes fossasia#1153: Added RSS and JSON link * Made JSON and RSS links at bottom in large screens Fixes fossasia#1157: Restored Node to version 6 in .travis.yml (fossasia#1158) Fixes fossasia#1159: Removed hardcoded url from RSS and JSON links (fossasia#1160) Fixes fossasia#1162: Reverted color of 'More at Wikipedia' text (fossasia#1164) Fixes fossasia#1161 fossasia#1163: Removed GitHub Links of Images and Added Badgeyay logo to service box. (fossasia#1165) * Fixes fossasia#1161: Removed GitHub links of images * Fixes fossasia#1163: Added Badgeyay Logo to the service box Fixes fossasia#1122 Next Button Location (fossasia#1146) * Fixes fossasia#1122 Next Button Location * Fixed movement of pagination * Made Next and Previous text in line with page numbers command to setup locally corrected Remove useless Commands Phase name change to Angular Installation Minor improvements in README.md Minor corrections Remove $ sign Minor improvement in readability Readability improvements in README.md Security Vulnerability in Gemfile.lock and package-lock.json fossasia#1176 (fossasia#1180) * command to setup locally corrected * security vulnerability corrected Add Mailto Tag in Contact Page (fossasia#1178) * mailto tag added * Update contact.component.html Add space between banner image and heading Fixes fossasia#1188 correction in docker doc Remove sort by date (fossasia#926) Fixes fossasia#1184 Updating Contact Page Fixes fossasia#1189 nodejs docker installation Fixes fossasia#1192 correct about yacy link (fossasia#1193) * Fixes fossasia#1192 correct about yacy link * Add variable for yacy site Footer Fixed at bottom (fossasia#1205) The footer bar of susper has been fixed at the bottom with the help of css. Fixes fossasia#1199 Centered Voice Search Icon Update 404.html Updated Badgeyay's icon (fossasia#1203) The badgeyay's icon on susper.com has been updated. Fixes fossasia#1201 Fixse fossasia#1306: Removed redundant package delarations (fossasia#1307) fixing (fossasia#1351) Update contact.component.ts Update contact.component.html Added sidebar for Privacy page and tests to increase coverage Fixes fossasia#956 content for help section Center Settings and Tools Menu Items Fixing About page css (fossasia#1298) Fixes fossasia#1227 close button to the right (fossasia#1228) Fixes fossasia#1225 adding help in footer (fossasia#1226) Fixing the hovering and visited color of links (fossasia#1293) * Changing color of hovering , Visited link Ignoring the overriden of tags of hover and visited * Changing color Added share link and made styles changes to infobox-share-popup (fossasia#1349) Revert "Center Settings and Tools Menu Items" (fossasia#1231) * Revert "Fixes fossasia#1225 adding help in footer (fossasia#1226)" This reverts commit a727075. * Revert "Fixes fossasia#1227 close button to the right (fossasia#1228)" This reverts commit ae71a6a. * Revert "Center Settings and Tools Menu Items" This reverts commit d20bbcd. "Update the issue template " (fossasia#1219) Fix 1268 - Fix overlapping Help Section with footer (fossasia#1271) * Updated Badgeyay's icon (fossasia#1203) The badgeyay's icon on susper.com has been updated. Fixes fossasia#1201 * "Commit " Fixed overlapping footer, fossasia#1216 (fossasia#1224) add twitter links (fossasia#1236) Fixes fossasia#1242 corrections in crawl job page (fossasia#1243) Refactored Help Component and Added tests for increasing coverage Fix fossasia#1388 : did you mean content is now clickable Refactors Theme Component and added tests for coverage Added YouTube link in the infobox (fossasia#1247) Add Flex Slider to Help Videos (fossasia#1234) Switch Lint Fixes fossasia#1310: Travis issue fixed (fossasia#1207)Added link to map address Fixed Contact Form UI (fossasia#1257) Added/Updated tests cursor chnages to hover Fix 1179 - Add SUSI.AI for Magic Mirror, Yaydoc, Meilix and Phimp.me in Projects section under the menus icon in the navbar add a share button to infobox add a share button to infobox fix indentation add modal add icons fix linting errors fix icons fix travis build errors fix whitespace fix whitespace format HTML add borders improve styles increase padding Fixes fossasia#1322: About component refactored and cleaned up Style and link fixes on the Privacy and Terms page(fossasia#1261) Fixes fossasia#1267: Infobox share modal, styling fixes, redundancies removed changes title according to search depth field only accepts numbers Adding rel="noopener" for fixing cross-link links fix footer Fixed validations in Contact form Made active theme button different from others Fixed linting issue Fixed formatting of code Fixed clear search issue fossasia#1230 Fixed double quotes to single quotes Fixed reference for navbar html Fixed spacing issues in constructor scope Fixed clear search issue fossasia#1230 Fixing the susper logo alignment and its container Fixing alignment for all screen sizes Fixing width of div Update index.component.html Update index.component.css Update index.component.html Update index.component.css Update index.component.css Update index.component.css Update index.component.css Fixed a typo in the contact form New Design of about component The design of the about component has been changed Fixes fossasia#1221 Analytics border lie inside the window (fossasia#1346) Susper logo Addition Update README.md Fixed UI of Advanced Search Page Added sidebar menu on Terms page and tests to increase coverage Fixing not found result page Update results.component.ts Update results.component.ts Update results.component.html Update results.component.html Fixes fossasia#1327: Contact componnet refactored (fossasia#1328) Fixes fossasia#1317: Reducers and Actions cleaned (fossasia#1318)
subhahu123
added a commit
to subhahu123/susper.com
that referenced
this pull request
Mar 1, 2019
Fixes fossasia#1327: Contact componnet refactored (fossasia#1328) Fixes fossasia#1317: Reducers and Actions cleaned (fossasia#1318) Made active theme button different from others Fixed clear search issue fossasia#1230 Fixed double quotes to single quotes Fixed reference for navbar html Fixed spacing issues in constructor scope Fixed clear search issue fossasia#1230 Refactors Theme Component and added tests for coverage Added YouTube link in the infobox (fossasia#1247) Add Flex Slider to Help Videos (fossasia#1234) Switch Lint Analytics border lie inside the window (fossasia#1346) (fossasia#1207)Added link to map address Fixed Contact Form UI (fossasia#1257) Fixed UI of Advanced Search Page Fixes fossasia#1327: Contact componnet refactored (fossasia#1328) Fix 1179 - Add SUSI.AI for Magic Mirror, Yaydoc, Meilix and Phimp.me in Projects section under the menus icon in the navbar add a share button to infobox add a share button to infobox fix indentation add modal add icons fix linting errors fix icons fix travis build errors fix whitespace fix whitespace format HTML add borders improve styles increase padding Tests Added (fossasia#1278) * Tests Added Some of the tests for the files have been added * Tests Added Some of the tests for the newly added functions have been added Style and link fixes on the Privacy and Terms page(fossasia#1261) Fixes fossasia#1267: Infobox share modal, styling fixes, redundancies removed fixing (fossasia#1351) Update contact.component.ts Update contact.component.html Fixes fossasia#1317: Reducers and Actions cleaned (fossasia#1318) fix footer Fixed validations in Contact form Added share link and made styles changes to infobox-share-popup (fossasia#1349) Fixed linting issue Fixed formatting of code Refactored Help Component and Added tests for increasing coverage Fixed a typo in the contact form New Design of about component The design of the about component has been changed Fixes fossasia#1221 cursor chnages to hover Susper logo Addition Update README.md depth field only accepts numbers Fixed minor link and ui issues Loading animation added to result component (fossasia#1204) Fixing the susper logo alignment and its container Fixing alignment for all screen sizes Fixing width of div Update index.component.html Update index.component.css Update index.component.html Update index.component.css Update index.component.css Update index.component.css Update index.component.css Fixes fossasia#1308: Refactor app.modules.ts (fossasia#1309) Fixse fossasia#1306: Removed redundant package delarations (fossasia#1307) Added sidebar menu on Terms page and tests to increase coverage Fixing About page css (fossasia#1298) Fixing the hovering and visited color of links (fossasia#1293) * Changing color of hovering , Visited link Ignoring the overriden of tags of hover and visited * Changing color Added sidebar for Privacy page and tests to increase coverage Fix 1268 - Fix overlapping Help Section with footer (fossasia#1271) * Updated Badgeyay's icon (fossasia#1203) The badgeyay's icon on susper.com has been updated. Fixes fossasia#1201 * "Commit " Fixes fossasia#1242 corrections in crawl job page (fossasia#1243) Fix fossasia#1388 : did you mean content is now clickable Fixes fossasia#1310: Travis issue fixed Added/Updated tests Adding rel="noopener" for fixing cross-link links Fixes fossasia#1322: About component refactored and cleaned up changes title according to search Fixing not found result page Update results.component.ts Update results.component.ts Update results.component.html Update results.component.html Update dropdown.css To hide overflow along x-axis in the dropdown to give UI effect similar to that of Google Search Update about.component.html Update about.component.html Update about.component.html Update about.component.html Update about.component.html Update about.component.html Update about.component.html Update about.component.html Update about.component.html Update about.component.html Update about.component.html Adding a lang attribute to the html element refactored type changed Search bar is fixed when scrolled Removed fixed navbar for mobile Changed shape of search-bar to curve shape (fossasia#1462) * Changed shape of search-bar to curve shape * Improved the corner of search-bar Merge branch 'development' of https://github.com/fossasia/susper.com into fossasia-development Merge branch 'fossasia-development' into development Conflicts: Removing unused imports from services Update knowledgeapi.service.ts remove unused imports Update search.service.ts remove unused imports from components rebasing the branch Please enter the commit message for your changes. Lines starting Update 404.html Delete Pslab.webp Delete RssOrange.webp Delete YaCyLogo2011_60.webp Delete meilix.webp Delete microphone.webp Delete loklak.webp Delete mountain.webp Delete not-found-bg.webp Delete phimp.webp Delete susimagicmirror.webp Delete terminal.webp Delete yaydoc.webp Delete susper.webp Delete susi_60x12.webp Delete search.webp Update newadvancedsearch.component.css
subhahu123
added a commit
to subhahu123/susper.com
that referenced
this pull request
Mar 1, 2019
Fixed clear search issue fossasia#1230 Fixed double quotes to single quotes Fixed reference for navbar html Fixed spacing issues in constructor scope Fixed clear search issue fossasia#1230 Add Flex Slider to Help Videos (fossasia#1234) Switch Lint (fossasia#1207)Added link to map address Analytics border lie inside the window (fossasia#1346) Refactors Theme Component and added tests for coverage Fixed Contact Form UI (fossasia#1257) Fix 1179 - Add SUSI.AI for Magic Mirror, Yaydoc, Meilix and Phimp.me in Projects section under the menus icon in the navbar Fixed UI of Advanced Search Page add a share button to infobox add a share button to infobox fix indentation add modal add icons fix linting errors fix icons fix travis build errors fix whitespace fix whitespace format HTML add borders improve styles increase padding Style and link fixes on the Privacy and Terms page(fossasia#1261) Tests Added (fossasia#1278) * Tests Added Some of the tests for the files have been added * Tests Added Some of the tests for the newly added functions have been added Fixes fossasia#1327: Contact componnet refactored (fossasia#1328) Fixes fossasia#1267: Infobox share modal, styling fixes, redundancies removed fix footer fixing (fossasia#1351) Update contact.component.ts Update contact.component.html Fixed validations in Contact form Fixed linting issue Added share link and made styles changes to infobox-share-popup (fossasia#1349) Fixes fossasia#1317: Reducers and Actions cleaned (fossasia#1318) Fixed formatting of code Fixed a typo in the contact form Refactored Help Component and Added tests for increasing coverage New Design of about component The design of the about component has been changed Fixes fossasia#1221 Susper logo Addition cursor chnages to hover Update README.md Fixed minor link and ui issues depth field only accepts numbers Loading animation added to result component (fossasia#1204) Fixes fossasia#1308: Refactor app.modules.ts (fossasia#1309) Fixing the susper logo alignment and its container Fixing alignment for all screen sizes Fixing width of div Update index.component.html Update index.component.css Update index.component.html Update index.component.css Update index.component.css Update index.component.css Update index.component.css Fixse fossasia#1306: Removed redundant package delarations (fossasia#1307) Fixing About page css (fossasia#1298) Added sidebar menu on Terms page and tests to increase coverage Fixing the hovering and visited color of links (fossasia#1293) * Changing color of hovering , Visited link Ignoring the overriden of tags of hover and visited * Changing color Fix 1268 - Fix overlapping Help Section with footer (fossasia#1271) * Updated Badgeyay's icon (fossasia#1203) The badgeyay's icon on susper.com has been updated. Fixes fossasia#1201 * "Commit " Added sidebar for Privacy page and tests to increase coverage Fixes fossasia#1242 corrections in crawl job page (fossasia#1243) Fixes fossasia#1310: Travis issue fixed Fix fossasia#1388 : did you mean content is now clickable Added/Updated tests Fixes fossasia#1322: About component refactored and cleaned up Adding rel="noopener" for fixing cross-link links Update dropdown.css To hide overflow along x-axis in the dropdown to give UI effect similar to that of Google Search Update about.component.html Update about.component.html Update about.component.html Update about.component.html Update about.component.html Update about.component.html Update about.component.html Update about.component.html Update about.component.html Update about.component.html Update about.component.html Adding a lang attribute to the html element refactored type changed Search bar is fixed when scrolled Removed fixed navbar for mobile Changed shape of search-bar to curve shape (fossasia#1462) * Changed shape of search-bar to curve shape * Improved the corner of search-bar Merge branch 'development' of https://github.com/fossasia/susper.com into fossasia-development Merge branch 'fossasia-development' into development Conflicts:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1352 , #1358
Checklist
masterbranch.Changes proposed in this pull request:
Current behavior:
Require attribute is not working
It does not require name,phone, number , email id to submit the form or enabling the submit button
Just give input of more than 100 words and it's done