Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed shape of search-bar to curve shape #1462

Merged
merged 2 commits into from
Feb 28, 2019

Conversation

div12gau
Copy link
Member

@div12gau div12gau commented Feb 26, 2019

Fixes #1449

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • I have added necessary documentation (if appropriate)
  • Added Surge preview link

Changes proposed in this pull request:

  • Changed the shape of search-bar to curve shape
  • image

Copy link
Member

@praveenojha33 praveenojha33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at the corner of the search box.
image

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #1462 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           development   #1462   +/-   ##
===========================================
  Coverage         62.2%   62.2%           
===========================================
  Files               51      51           
  Lines             1450    1450           
  Branches           181     181           
===========================================
  Hits               902     902           
  Misses             437     437           
  Partials           111     111

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbb9a18...2639ea2. Read the comment docs.

Copy link
Member

@praveenojha33 praveenojha33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
However I think we should decrease the size of search box when it is scrolled on result page.
Please do it in this PR or open an issue for it.
image
Thank You !!

@praveenojha33
Copy link
Member

@shreyanshdwivedi @AakashMallik Please review.

Copy link
Contributor

@Pipe-Runner Pipe-Runner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

Copy link
Member

@neeraj3029 neeraj3029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhaveshAn bhaveshAn merged commit e6a0c40 into fossasia:development Feb 28, 2019
subhahu123 added a commit to subhahu123/susper.com that referenced this pull request Mar 1, 2019
Fixes fossasia#1327: Contact componnet refactored (fossasia#1328)


Fixes  fossasia#1317: Reducers and Actions cleaned (fossasia#1318)


Made active theme button different from others

Fixed clear search issue fossasia#1230

Fixed double quotes to single quotes

Fixed reference for navbar html

Fixed spacing issues in constructor scope

Fixed clear search issue fossasia#1230

Refactors Theme Component and added tests for coverage

Added YouTube link in the infobox (fossasia#1247)


Add Flex Slider to Help Videos (fossasia#1234)

Switch

Lint
Analytics border lie inside the window (fossasia#1346)


(fossasia#1207)Added link to map address

Fixed Contact Form UI (fossasia#1257)

Fixed UI of Advanced Search Page

Fixes fossasia#1327: Contact componnet refactored (fossasia#1328)


Fix 1179 - Add SUSI.AI for Magic Mirror, Yaydoc, Meilix and Phimp.me in Projects section under the menus icon in the navbar

add a share button to infobox

add a share button to infobox

fix indentation

add modal

add icons

fix linting errors

fix icons

fix travis build errors

fix whitespace

fix whitespace

format HTML

add borders

improve styles

increase padding

Tests Added (fossasia#1278)

* Tests Added

Some of the tests for the files have been added

* Tests Added

Some of the tests for the newly added functions have been added

Style and link fixes on the Privacy and Terms page(fossasia#1261)

Fixes fossasia#1267: Infobox share modal, styling fixes, redundancies removed

fixing (fossasia#1351)

Update contact.component.ts
Update contact.component.html
Fixes  fossasia#1317: Reducers and Actions cleaned (fossasia#1318)


fix footer

Fixed validations in Contact form

Added share link and made styles changes to infobox-share-popup (fossasia#1349)


Fixed linting issue

Fixed formatting of code

Refactored Help Component and Added tests for increasing coverage

Fixed a typo in the contact form

New Design of about component

The design of the about component has been changed

Fixes fossasia#1221

cursor chnages to hover

Susper logo Addition
Update README.md
depth field only accepts numbers

Fixed minor link and ui issues

Loading animation added to result component (fossasia#1204)


Fixing the susper logo alignment and its container
Fixing alignment for all screen sizes
Fixing width of div
Update index.component.html
Update index.component.css
Update index.component.html
Update index.component.css
Update index.component.css
Update index.component.css
Update index.component.css
Fixes fossasia#1308: Refactor app.modules.ts (fossasia#1309)


Fixse fossasia#1306: Removed redundant package delarations (fossasia#1307)


Added sidebar menu on Terms page and tests to increase coverage

Fixing About page css (fossasia#1298)


Fixing the hovering and visited color of links (fossasia#1293)

* Changing color of hovering , Visited link 

Ignoring the overriden of tags of hover and visited

* Changing color

Added sidebar for Privacy page and tests to increase coverage

Fix 1268 - Fix overlapping Help Section with footer (fossasia#1271)

* Updated Badgeyay's icon (fossasia#1203)

The badgeyay's icon on susper.com has been updated.

Fixes fossasia#1201

* "Commit "

Fixes fossasia#1242 corrections in crawl job page (fossasia#1243)


Fix fossasia#1388 : did you mean content is now clickable

Fixes fossasia#1310: Travis issue fixed

Added/Updated tests

Adding rel="noopener" for fixing cross-link links
Fixes fossasia#1322: About component refactored and cleaned up

changes title according to search

Fixing not found result page
Update results.component.ts
Update results.component.ts
Update results.component.html
Update results.component.html
Update dropdown.css

To hide overflow along x-axis in the dropdown to give UI effect similar to that of Google Search
Update about.component.html
Update about.component.html
Update about.component.html
Update about.component.html
Update about.component.html
Update about.component.html
Update about.component.html
Update about.component.html
Update about.component.html
Update about.component.html
Update about.component.html
Adding a lang attribute to the html element
refactored

type changed

Search bar is fixed when scrolled

Removed fixed navbar for mobile

Changed shape of search-bar to curve shape (fossasia#1462)

* Changed shape of search-bar to curve shape

* Improved the corner of search-bar

Merge branch 'development' of https://github.com/fossasia/susper.com into fossasia-development

Merge branch 'fossasia-development' into development

Conflicts:

Removing unused imports from services
Update knowledgeapi.service.ts
remove unused imports
Update search.service.ts
remove unused imports from components
rebasing the branch

Please enter the commit message for your changes. Lines starting

Update 404.html
Delete Pslab.webp
Delete RssOrange.webp
Delete YaCyLogo2011_60.webp
Delete meilix.webp
Delete microphone.webp
Delete loklak.webp
Delete mountain.webp
Delete not-found-bg.webp
Delete phimp.webp
Delete susimagicmirror.webp
Delete terminal.webp
Delete yaydoc.webp
Delete susper.webp
Delete susi_60x12.webp
Delete search.webp
Update newadvancedsearch.component.css
subhahu123 added a commit to subhahu123/susper.com that referenced this pull request Mar 1, 2019
Fixed clear search issue fossasia#1230

Fixed double quotes to single quotes

Fixed reference for navbar html

Fixed spacing issues in constructor scope

Fixed clear search issue fossasia#1230

Add Flex Slider to Help Videos (fossasia#1234)

Switch

Lint
(fossasia#1207)Added link to map address

Analytics border lie inside the window (fossasia#1346)


Refactors Theme Component and added tests for coverage

Fixed Contact Form UI (fossasia#1257)

Fix 1179 - Add SUSI.AI for Magic Mirror, Yaydoc, Meilix and Phimp.me in Projects section under the menus icon in the navbar

Fixed UI of Advanced Search Page

add a share button to infobox

add a share button to infobox

fix indentation

add modal

add icons

fix linting errors

fix icons

fix travis build errors

fix whitespace

fix whitespace

format HTML

add borders

improve styles

increase padding

Style and link fixes on the Privacy and Terms page(fossasia#1261)

Tests Added (fossasia#1278)

* Tests Added

Some of the tests for the files have been added

* Tests Added

Some of the tests for the newly added functions have been added

Fixes fossasia#1327: Contact componnet refactored (fossasia#1328)


Fixes fossasia#1267: Infobox share modal, styling fixes, redundancies removed

fix footer

fixing (fossasia#1351)

Update contact.component.ts
Update contact.component.html
Fixed validations in Contact form

Fixed linting issue

Added share link and made styles changes to infobox-share-popup (fossasia#1349)


Fixes  fossasia#1317: Reducers and Actions cleaned (fossasia#1318)


Fixed formatting of code

Fixed a typo in the contact form

Refactored Help Component and Added tests for increasing coverage

New Design of about component

The design of the about component has been changed

Fixes fossasia#1221

Susper logo Addition
cursor chnages to hover

Update README.md
Fixed minor link and ui issues

depth field only accepts numbers

Loading animation added to result component (fossasia#1204)


Fixes fossasia#1308: Refactor app.modules.ts (fossasia#1309)


Fixing the susper logo alignment and its container
Fixing alignment for all screen sizes
Fixing width of div
Update index.component.html
Update index.component.css
Update index.component.html
Update index.component.css
Update index.component.css
Update index.component.css
Update index.component.css
Fixse fossasia#1306: Removed redundant package delarations (fossasia#1307)


Fixing About page css (fossasia#1298)


Added sidebar menu on Terms page and tests to increase coverage

Fixing the hovering and visited color of links (fossasia#1293)

* Changing color of hovering , Visited link 

Ignoring the overriden of tags of hover and visited

* Changing color

Fix 1268 - Fix overlapping Help Section with footer (fossasia#1271)

* Updated Badgeyay's icon (fossasia#1203)

The badgeyay's icon on susper.com has been updated.

Fixes fossasia#1201

* "Commit "

Added sidebar for Privacy page and tests to increase coverage

Fixes fossasia#1242 corrections in crawl job page (fossasia#1243)


Fixes fossasia#1310: Travis issue fixed

Fix fossasia#1388 : did you mean content is now clickable

Added/Updated tests

Fixes fossasia#1322: About component refactored and cleaned up

Adding rel="noopener" for fixing cross-link links
Update dropdown.css

To hide overflow along x-axis in the dropdown to give UI effect similar to that of Google Search
Update about.component.html
Update about.component.html
Update about.component.html
Update about.component.html
Update about.component.html
Update about.component.html
Update about.component.html
Update about.component.html
Update about.component.html
Update about.component.html
Update about.component.html
Adding a lang attribute to the html element
refactored

type changed

Search bar is fixed when scrolled

Removed fixed navbar for mobile

Changed shape of search-bar to curve shape (fossasia#1462)

* Changed shape of search-bar to curve shape

* Improved the corner of search-bar

Merge branch 'development' of https://github.com/fossasia/susper.com into fossasia-development

Merge branch 'fossasia-development' into development

Conflicts:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change in search bar
6 participants