-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added scores.yml #125
Added scores.yml #125
Conversation
can you add all students name as well in the file |
Ok sure. Just the names, or any other details as well? |
I was planning to have each student's name, image, github username attributes along with the mandatory total and contributions fields. |
I was thinking each student would have details listed out in this fashion -
|
yeah this looks better , i fear the file will get too large |
I don't think it can be helped if you want to store all the contributions |
So after every successfull pull reuqest, we will have to add the data in this file. Right? |
Yes that's the plan |
i think its better to have a contributions.yml file with student name , but this work too @adeora7 @shubham-padia what do you guys say ? |
could you please elaborate. You mean one file for each student ? @gauthamzz |
Instead we can have the students list out the breakdown of points and link of all pull requests in a separate gist file and give a link to that file. Participants will have to change the total with each pull request and update the gist accordingly |
i mean like make a file points.yml
will be there or should we jsut add it in students.yml |
i like @shubham-padia 's idea |
@shubham-padia 's idea sounds nice. But then all the gists need to have a fixed format, JSON perhaps. But still, if it is a gist, we would lose control over the list of contributions. The participant may/may not update them, or the participant may follow different format. |
And a gist is more of an individual thing, it seems like we separating an event related entity from the event itself. |
we need to figure out a solution fast :/ |
If we have contributions in the |
you are right @VamsiSangam but if we write everything in students.yml small changes may cause it to break. thats why thought of having a seperate yml file. a simple loop will also work in this case. |
I never meant to put everything in students.yml . My plan was to create
That's for me, everyone would list out theirs. It will make it big, but it is separation of concerns. Details of students in students.yml and contribution (which includes scores) in scores.yml |
i think we shouldnt have duplicate data. i think github username will be sufficient and we can pick up others from the students.yml file |
Ok then this is what would go into scores.yml -
Is this what you meant? |
github id will be like a primary key , yeah exactly |
Ok we will wait for what @shubham-padia and @adeora7 have to say about this. Meanwhile, let's say I have my primary key value, say |
#125 (comment) Sounds good. Implement it for now, if we face any issues with this approach we can always change it 😛 |
Please review the format. If everything's okay, after the merge I will create an issue asking others to fill in their contributions. |
Adding empty
scores.yml
. This is for the rankings as discussed with @gauthamzz in #64 . After this merge, I will create a new issue asking students to add details of their contributions into this file.