Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checksumming #39

Merged
merged 10 commits into from Feb 20, 2021
Merged

Checksumming #39

merged 10 commits into from Feb 20, 2021

Conversation

fosslinux
Copy link
Owner

TODO: Reuse

@fosslinux fosslinux marked this pull request as ready for review February 18, 2021 07:37
@fosslinux
Copy link
Owner Author

This should now be finished and ready

stikonas
stikonas reviewed Feb 18, 2021
View reviewed changes
Copy link
Collaborator

@stikonas stikonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, although, it might be hard to manually update all hashes if we change some core component... E.g. patch tcc which will affect all hashes.

rootfs.sh Outdated Show resolved Hide resolved
@fosslinux
Copy link
Owner Author

I don't believe the tcc use case will happen very often, however, I do understand the issue. I'm considering some solutions to this including:

  • I want to split out all of the rms we do in src_install() anyways into a src_clean(), so perhaps we can add some option to disable that.
  • We could also add a way of making the resulting binaries be sha256summed automatically after something is set.

However, I'll add that after this PR.

I'm just adding Perl now then I'll merge

@fosslinux fosslinux force-pushed the checksumming branch 2 times, most recently from 40c37df to 76e27c5 Compare February 19, 2021 23:49
@fosslinux
Add fletcher16 impl to mescc-tools-extra
71505bc
@fosslinux
Add fletcher16-gen developer util
192221a 
1. I'm not convinced our fletcher16 implementation is proper
2. It is not in coreutils

So we add some basic code to do that.

This is also the first dev-util, so add some documentation to DEVEL.md.
@fosslinux
Implement fletcher16 checksumming up to path
372e08e 
Uses fletcher16 from previous commits.
Next we will use sha-2 to do checksumming.
@fosslinux
Add optional output_filename argument in rootfs.sh
44bad27 
Downloads to a particular filename, allows for different names than
whatever is upstream.
@fosslinux
Add sha-2 (commit 61155d)
92cb054 
Unfortunatley the sha2 project does not have versioned releases so we
use the latest commit.

We have also manually added a frontend to sha-2 to allow us to invoke
it from the command line, thanks bittrof for the help!
@fosslinux
Recheck all of the fletcher16 using sha-2
d6780c9 
Ensure validity at a higher bit depth
@fosslinux
Implement sha256summing for all remaining kaem scripts
8724c94
@fosslinux
Implement sha256summing in bash build harness
77ccf06 
1. Adds sha256sum stage to the bash build harness.
2. Adds a third argument to build(), the checksum file name. This is
   used where there is more than one checksum file, most notably
   in multi-stage compilations.
3. Adds checksum files to all remaining programs.
4. Adds appropriate 3rd argument where needed (coreutils, tcc-musl,
   bison).
@fosslinux
Add guidelines regarding checksumming to DEVEL.md
f1a2910
@fosslinux
Add perl checksums
87b303f 
And the gawk change, fix checksums for that as well

For commit e2796e8.
@fosslinux fosslinux merged commit 7099319 into master Feb 20, 2021
@fosslinux fosslinux deleted the checksumming branch February 28, 2021 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stikonas stikonas stikonas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fosslinux @stikonas