fix(license_patch): Fix bug in license patch request #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: deo002 <oberoidearsh@gmail.com>
avinal
reviewed
Apr 11, 2024
Comment on lines
+45
to
+65
| type LicensePOSTRequestJSONSchema struct { | ||
| Shortname string `json:"rf_shortname" binding:"required" example:"MIT"` | ||
| Fullname string `json:"rf_fullname" binding:"required" example:"MIT License"` | ||
| Text string `json:"rf_text" binding:"required" example:"MIT License Text here"` | ||
| Url string `json:"rf_url" binding:"required" example:"https://opensource.org/licenses/MIT"` | ||
| Copyleft bool `json:"rf_copyleft" binding:"required"` | ||
| FSFfree bool `json:"rf_FSFfree" binding:"required"` | ||
| OSIapproved bool `json:"rf_OSIapproved" binding:"required"` | ||
| GPLv2compatible bool `json:"rf_GPLv2compatible" binding:"required"` | ||
| GPLv3compatible bool `json:"rf_GPLv3compatible" binding:"required"` | ||
| Notes string `json:"rf_notes" example:"This license has been superseded." binding:"required"` | ||
| Fedora string `json:"rf_Fedora" binding:"required"` | ||
| TextUpdatable bool `json:"rf_text_updatable" binding:"required"` | ||
| DetectorType int64 `json:"rf_detector_type" example:"1" binding:"required"` | ||
| Active bool `json:"rf_active" binding:"required"` | ||
| Source string `json:"rf_source" binding:"required"` | ||
| SpdxId string `json:"rf_spdx_id" binding:"required" example:"MIT"` | ||
| Risk int64 `json:"rf_risk" binding:"required"` | ||
| Flag int64 `json:"rf_flag" binding:"required" example:"1"` | ||
| Marydone bool `json:"marydone" binding:"required"` | ||
| ExternalRef datatypes.JSONType[LicenseDBSchemaExtension] `json:"external_ref" binding:"required"` |
There was a problem hiding this comment.
I can see binding required in all the fields. Does that mean we cannot create a license without providing all the fields?
There was a problem hiding this comment.
Yes, while creating the license all the fields are required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the following:
Example:
{
"active": false,
"text": "Lorem ipsum"
}
and
{
"text": "Lorem ipsum"
}
Structs of both these unmarshalled json objects will have active as false.