Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License Browser Scanner Count is off #27

Closed
bobgob opened this issue Dec 4, 2014 · 15 comments
Closed

License Browser Scanner Count is off #27

bobgob opened this issue Dec 4, 2014 · 15 comments
Assignees

Comments

@bobgob
Copy link
Member

bobgob commented Dec 4, 2014

It looks like the License Browser "Scanner Count" is summing the results from multiple versions of the license scanner. For example, if both version 1 and 2 of nomos produced 1 Public-domain each, then the Scanner Count would show 2 instead of 1 for the last scan. I'm only speculating here.

Sorry for the HP internal URL:
http://bobg.fc.hp.com/fossology/?mod=license&upload=257&item=21270940
I've attached a screenshot in case this helps:

screen shot 2014-12-04 at 10 51 51 am

@wuan wuan self-assigned this Dec 4, 2014
@wuan wuan closed this as completed in 42b248c Dec 4, 2014
bobgob pushed a commit that referenced this issue Dec 4, 2014
fixed #27 - multiple scanner agent versions are added up in histogram statistics
@bobgob
Copy link
Member Author

bobgob commented Dec 4, 2014

I just tested and the issue is not fixed. I get the same results as before.

@bobgob bobgob reopened this Dec 4, 2014
@bobgob
Copy link
Member Author

bobgob commented Dec 4, 2014

sorry. My mistake. I was looking at a cached page. Closing.

@bobgob bobgob closed this as completed Dec 4, 2014
@bobgob
Copy link
Member Author

bobgob commented Dec 4, 2014

Reopening. The Scanner Count did change but it does not match the number of files displayed in "List Files for License"

@bobgob bobgob reopened this Dec 4, 2014
@wuan
Copy link
Member

wuan commented Dec 4, 2014

So i think we have a similar problem on the license_list_files page.

<total_count> files found (<unique_count> unique) with license <license_shortname>

Total count is again containing results of multiple agent versions.

@bobgob
Copy link
Member Author

bobgob commented Dec 4, 2014

That message was changed yesterday. Do a git pull.

@bobgob
Copy link
Member Author

bobgob commented Dec 4, 2014

In case there a misunderstanding of what the License Browser should be displaying, let me go over that. By default, only the latest results should be displayed. For example, say you have Monk 2.5.0, Monk 2.6.1, Nomos 2.5.0 and Nomos 2.6.1 scans. By default, the results for Monk 2.6.1 and Nomos 2.6.1 should be displayed. This should not include the 2.5.0 results. The pull down lets you recall older results.

@wuan
Copy link
Member

wuan commented Dec 4, 2014

The license_list_files page shows the unique file count in the beginning and the number of files listed is identical to the number of files with the particular license.
As I assume that the number of files (not unique files) is relevant here, I will try to fix this as well.

@bobgob bobgob closed this as completed in ee3d71e Dec 4, 2014
@wuan
Copy link
Member

wuan commented Dec 4, 2014

fixing the license_list_files page would be rather expensive, please file another issue if this is required.

@bobgob
Copy link
Member Author

bobgob commented Dec 4, 2014

My tests show that List Files for License and the License Browser Scanner count now agree with each other. Thank you!

@yaobinshi
Copy link
Contributor

for this commit 3128584

I have a question:
one file has multiple BSD-3-Clause license text, so monk will report multiple BSD-3-Clause for this file,
the 'Scanner Count' will count multiple times, so the file count may less than the 'Scanner Count'.
from my perspective, my check in is better on the notice description, or others?

@yaobinshi yaobinshi reopened this Dec 5, 2014
@wuan
Copy link
Member

wuan commented Dec 5, 2014

The count displayed at the beginning of the license file list is the number of unique files having at least one appearance of the license. Whereas the file listing below counts unique files multiple times. Files with identical content are grouped together but counted individually.

If files with identical content exist in this view, the users may be irritated due to the different numbers.

@yaobinshi
Copy link
Contributor

Ok, why I asked the question above is because, I have one archive, 'Monk Scanner Count' is 5 BSD-3-Clause on license browser page, however the file count is 2 on List Files for License page, as one file is returned 4 BSD-3-Clause by monk, another file is return a BSD-3-Clause by monk.

@wuan
Copy link
Member

wuan commented Dec 5, 2014

The scanner count should count multiple licenses per file individually. Would this be the expected behaviour here?
The file list does not repeat files if the same license is found at multiple location. So we can expect differences in count.

@yaobinshi
Copy link
Contributor

Will talk with others to get more opinions, let us keep it. thanks.

@mcjaeger
Copy link
Member

Andreas' (wuan) sounds reasonable now, and since there has not been an update since 12 months, I am closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants