-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
License Browser Scanner Count is off #27
Comments
fixed #27 - multiple scanner agent versions are added up in histogram statistics
I just tested and the issue is not fixed. I get the same results as before. |
sorry. My mistake. I was looking at a cached page. Closing. |
Reopening. The Scanner Count did change but it does not match the number of files displayed in "List Files for License" |
So i think we have a similar problem on the
Total count is again containing results of multiple agent versions. |
That message was changed yesterday. Do a git pull. |
In case there a misunderstanding of what the License Browser should be displaying, let me go over that. By default, only the latest results should be displayed. For example, say you have Monk 2.5.0, Monk 2.6.1, Nomos 2.5.0 and Nomos 2.6.1 scans. By default, the results for Monk 2.6.1 and Nomos 2.6.1 should be displayed. This should not include the 2.5.0 results. The pull down lets you recall older results. |
The |
fixing the |
My tests show that List Files for License and the License Browser Scanner count now agree with each other. Thank you! |
for this commit 3128584 I have a question: |
The count displayed at the beginning of the license file list is the number of unique files having at least one appearance of the license. Whereas the file listing below counts unique files multiple times. Files with identical content are grouped together but counted individually. If files with identical content exist in this view, the users may be irritated due to the different numbers. |
Ok, why I asked the question above is because, I have one archive, 'Monk Scanner Count' is 5 BSD-3-Clause on license browser page, however the file count is 2 on List Files for License page, as one file is returned 4 BSD-3-Clause by monk, another file is return a BSD-3-Clause by monk. |
The scanner count should count multiple licenses per file individually. Would this be the expected behaviour here? |
Will talk with others to get more opinions, let us keep it. thanks. |
Andreas' (wuan) sounds reasonable now, and since there has not been an update since 12 months, I am closing |
It looks like the License Browser "Scanner Count" is summing the results from multiple versions of the license scanner. For example, if both version 1 and 2 of nomos produced 1 Public-domain each, then the Scanner Count would show 2 instead of 1 for the last scan. I'm only speculating here.
Sorry for the HP internal URL:
http://bobg.fc.hp.com/fossology/?mod=license&upload=257&item=21270940
I've attached a screenshot in case this helps:
The text was updated successfully, but these errors were encountered: