feat(keyword-agent) : new-keyword-agent #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
shaheemazmalmmd
requested changes
May 23, 2018
src/copyright/agent/identity.hpp
Outdated
| @@ -1,6 +1,6 @@ | |||
| /* | |||
| * Copyright (C) 2014, Siemens AG | |||
There was a problem hiding this comment.
Please change the copyrights for all files.
ag4ums
force-pushed
the
contrib/agent-keyword
branch
from
00e7f97
to
115727b
Compare
|
Please change the commit message according to commit conventions. |
ag4ums
force-pushed
the
contrib/agent-keyword
branch
from
115727b
to
16ba498
Compare
|
Please add the below files to git ignore
|
ag4ums
force-pushed
the
contrib/agent-keyword
branch
from
16ba498
to
7a0c3ed
Compare
shaheemazmalmmd
approved these changes
Jul 10, 2018
GMishx
requested changes
Jul 11, 2018
src/copyright/agent/keyword.conf
Outdated
| # notice and this notice are preserved. This file is offered as-is, | ||
| # without any warranty. | ||
| # | ||
| # Description: this file holds the regex configurations for the IP agent |
There was a problem hiding this comment.
Please change to:
Description: This file holds the regex configurations for the Keyword agent
ag4ums
force-pushed
the
contrib/agent-keyword
branch
from
7a0c3ed
to
8379eac
Compare
src/copyright/ui/keyword-hist.php
Outdated
| @@ -0,0 +1,107 @@ | |||
| <?php | |||
| /*********************************************************** | |||
| * Copyright (C) 2010-2014 Hewlett-Packard Development Company, L.P. | |||
There was a problem hiding this comment.
This line can be removed
ag4ums
force-pushed
the
contrib/agent-keyword
branch
from
8379eac
to
ab30fbf
Compare
GMishx
reviewed
Aug 29, 2018
| @@ -338,7 +338,7 @@ public function getAllEntries($tableName, $uploadId, $uploadTreeTableName, $type | |||
| public function getDecisions($tableName,$pfileId) | |||
| { | |||
| $statementName = __METHOD__.$tableName; | |||
| $sql = "SELECT * FROM $tableName where pfile_fk = $1 and is_enabled order by copyright_decision_pk desc"; | |||
| $sql = "SELECT * FROM $tableName where pfile_fk = $1 and is_enabled order by keyword_decision_pk desc"; | |||
There was a problem hiding this comment.
@ag4ums
The change is breaking ECC view:
Warning: pg_prepare(): Query failed: ERROR: column "ecc_decision_pk" does not exist LINE 1: ...ision where pfile_fk = $1 and is_enabled order by ecc_decisi... ^ in /usr/local/share/fossology/lib/php/Db/Driver/Postgres.php on line 62
Fatal error: Uncaught Fossology\Lib\Exception:
error executing: SELECT * FROM ecc_decision where pfile_fk = $1 and is_enabled order by ecc_decision_pk desc -- Fossology\Lib\Dao\CopyrightDao::getDecisionsecc_decision
ERROR: column "ecc_decision_pk" does not exist LINE 1: ...ision where pfile_fk = $1 and is_enabled order by ecc_decisi... ^ in /usr/local/share/fossology/lib/php/Db/DbManager.php:140 Stack trace:
#0 /usr/local/share/fossology/lib/php/Db/ModernDbManager.php(51): Fossology\Lib\Db\DbManager->checkResult(false, 'SELECT * FROM e...')
#1 /usr/local/share/fossology/lib/php/Db/DbManager.php(183): Fossology\Lib\Db\ModernDbManager->prepare('Fossology\\Lib\\D...', 'SELECT * FROM e...')
#2 /usr/local/share/fossology/lib/php/Dao/CopyrightDao.php(345): Fossology\Lib\Db\DbManager->getRows('SELECT * FROM e...', Array, 'Fossology\\Lib\\D...')
#3 /usr/local/share/fossology/copyright/ui/Xpview.php(164): Fossology\Lib\Dao\CopyrightDao->getDecisions('ecc_decision', '16 in /usr/local/share/fossology/lib/php/Db/DbManager.php on line 140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.