Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obligation): add default value if the obligation type and classif… #1445

Merged
merged 1 commit into from Aug 20, 2019

Conversation

shaheemazmalmmd
Copy link
Contributor

…ication is empty

Description

Added check if type or classification is empty then set to default value.

How to test

Create a new obligation and check if the default values are already checked.

Closes #1439

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good

…ication is empty

Signed-off-by: Shaheem Azmal M MD <shaheem.azmal@siemens.com>
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing, working as expected.

@GMishx GMishx added ready and removed needs test labels Aug 20, 2019
@GMishx GMishx merged commit e401985 into fossology:master Aug 20, 2019
@GMishx GMishx deleted the contrib/fixIssue1439 branch August 20, 2019 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding an Obligation fails because missing default type
2 participants