Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker-compose): harmonize versions with sw360chores #1508

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

maxhbr
Copy link
Member

@maxhbr maxhbr commented Oct 22, 2019

The SW360chores docker compose project uses version 3.5. Bumping the version
here has no negative effects (except for probably old distributions having not a
new enough docker-compose, needs Docker Engine 17.12.0+).

The advantage is, that this allows the deployments to work in sync and one can
start both at the same time e.g. via:

./sw360chores.pl --build -- -f path/to/fossology/docker-compose.yml up

The SW360chores docker compose project uses version 3.5. Bumping the version
here has no negative effects (except for probably old distributions having not a
new enougth docker-compose, needs Docker Engine 17.12.0+).

The advantage is, that this allows the deployments to work in sync and one can
start both at the same time e.g. via:
```
./sw360chores.pl --build -- -f path/to/fossology/docker-compose.yml up
```

Signed-off-by: Maximilian Huber <maximilian.huber@tngtech.com>
@mcjaeger
Copy link
Member

I am not much into this, but if we narrow it down to 3.5 instead of 3.*, could we have maybe a lockout on specific distros because of the mapping between compose and docker itself? ... Because there is a mapping between file format version and docker engine (which is then imposed at 17.06?)

@maxhbr
Copy link
Member Author

maxhbr commented Oct 24, 2019

3.5 means, that we allow a special feature set in the compose files, which requires that the corresponding docker engine also supports that (and thus has at least a specific version). Since docker recommends to install itself directly, instead of via the package manager, the version should not be a problem and all distros should have access to a recent docker.

The version 3.5 also introduced features, which we require for sw360chores, but were not present in 3.4. So if we harmonize the version it has to be at least 3.5.

@mcjaeger mcjaeger self-requested a review November 5, 2019 08:47
Copy link
Member

@mcjaeger mcjaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version change sufficiently discussed in conversation

@mcjaeger mcjaeger added this to the 3.7.0 milestone Nov 5, 2019
@ag4ums ag4ums merged commit e19a49a into master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants