Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Remember assignee filter on Browse view #2013

Merged

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Jun 14, 2021

Description

Use cookies to remember the assignee filter value on the Browse view.

Changes

  1. Add new session cookie "assigneeSelected" to hold the filter value.

How to test

  1. On the browse view, filter the uploads based on assignment information.
  2. Open an upload, perform some action and go back to browse.
  3. The uploads should still be filtered by the assignee selected.

Closes #1927

Use cookies to remember the assignee filter value on the Browse view.

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Copy link
Member

@shaheemazmalmmd shaheemazmalmmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good. tested works as expected.

@shaheemazmalmmd shaheemazmalmmd merged commit 5576531 into fossology:master Jun 15, 2021
@GMishx GMishx deleted the feat/ui/remember-assigned-filter branch June 15, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assigned To filter on browse page
2 participants