Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reuse): REUSE best practices for licensing/copyright #2235

Conversation

rohitpandey49
Copy link
Contributor

@rohitpandey49 rohitpandey49 commented Jun 14, 2022

Signed-off-by: Rohit Pandey rohit.pandey4900@gmail.com

Description

REUSE best practices for licensing/copyright

Changes

  1. Added License File(a file containing the text of a license) in LICENSE folder
  2. Implemented correct licensing/copyright format

Current REUSE status

When running reuse lint over this branch, the result is as follows:

* Files with copyright information: 2619 / 4360
* Files with license information: 1066 / 4360

Before that we were at:

* Files with copyright information: 2616 / 4360
* Files with license information: 503 / 4360

@GMishx GMishx changed the base branch from master to contrib/reuse/change-repo-standard June 14, 2022 12:00
@shaheemazmalmmd shaheemazmalmmd added the GSoC-22 Label to tag issues and pull request for GSOC 2022 activities label Jun 14, 2022
Copy link
Member

@NicolasToussaint NicolasToussaint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I don't think the Author lines should be turned into Copyright statements, as they are different things.
See the REUSE FAQ

Additionally the empty line between License and Copyright statement, at least when there is just one each looks extraneous to me, but no big deal either.

src/cli/tests/ReadMe Outdated Show resolved Hide resolved
src/copyright/agent/copyscan.cc Outdated Show resolved Hide resolved
src/copyright/agent/copyscan.hpp Outdated Show resolved Hide resolved
src/copyright/agent_tests/Functional/shunit2 Show resolved Hide resolved
src/copyright/agent_tests/Functional/shunit2 Outdated Show resolved Hide resolved
src/copyright/ecc.conf Outdated Show resolved Hide resolved
src/copyright/keyword.conf Outdated Show resolved Hide resolved
@GMishx
Copy link
Member

GMishx commented Jun 21, 2022

@rohitpandey49 can you please squash all 3 commits into 1?

src/decider/Makefile Outdated Show resolved Hide resolved
Signed-off-by: rohitpandey49 <rohit.pandey4900@gmail.com>
@rohitpandey49
Copy link
Contributor Author

rohitpandey49 commented Jun 21, 2022

@rohitpandey49 can you please squash all 3 commits into 1?

Done

@GMishx GMishx merged commit fa5ce80 into fossology:contrib/reuse/change-repo-standard Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC-22 Label to tag issues and pull request for GSOC 2022 activities needs code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants