feat(API): list groups that can be deleted #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMishx
added
needs code review
needs test
GSoC-22
|
@dushimsam , can you please fix the branch so we can merge it? |
dushimsam
force-pushed
the
dushimsam/feat/has-group
branch
4 times, most recently
from
4262e75
to
6a8601a
Compare
dushimsam
changed the title
|
Done, you can review and let me know what's next to update if still available. |
dushimsam
force-pushed
the
dushimsam/feat/has-group
branch
2 times, most recently
from
24443ab
to
b1292aa
Compare
|
Completed tests for this controller. |
GMishx
approved these changes
Jul 13, 2022
|
Wow, thanks a lot sir. |
GMishx
reviewed
Jul 13, 2022
dushimsam
force-pushed
the
dushimsam/feat/has-group
branch
from
b1292aa
to
d128a6b
Compare
GMishx
reviewed
Jul 13, 2022
dushimsam
force-pushed
the
dushimsam/feat/has-group
branch
from
d128a6b
to
e0d5275
Compare
|
tested and working perfectly. |
GMishx
requested changes
Jul 17, 2022
dushimsam
force-pushed
the
dushimsam/feat/has-group
branch
from
e0d5275
to
fa56840
Compare
|
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
GMishx
requested changes
Aug 8, 2022
There was a problem hiding this comment.
@dushimsam Kindly rebase the branch with upstream master to resolve the merge conflicts.
dushimsam
force-pushed
the
dushimsam/feat/has-group
branch
from
fa56840
to
ca4c68a
Compare
dushimsam
force-pushed
the
dushimsam/feat/has-group
branch
from
ca4c68a
to
997e549
Compare
|
Ready now sir, kindly review and merge for me. |
GMishx
reviewed
Aug 9, 2022
dushimsam
force-pushed
the
dushimsam/feat/has-group
branch
from
997e549
to
99aa362
Compare
GMishx
approved these changes
Aug 12, 2022
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dushimsam dushsam100@gmail.com
Description
To check if the user has any group that is possible to be deleted.
Changes
GroupController. to check if the group exists.index.php) by adding a new route/groups/has-deletable-group.openapi.yamlfile to introduce a new API.How to test
http://localhost/repo/api/v1/groups/has-deletable-groupThe following property in the response body called
availableshould be marked as true if you have any group that is deletable , else it will always be marked as false.By default you have group
fossy, this one is not deletable , the deletable groups are the one you add afterwards.In other words , by default you don't have any deletable group , unless you start adding your own groups.
Related Issue:
Fixes #2246
cc: @shaheemazmalmmd @GMishx