-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(API): get admin-license candidates #2295
feat(API): get admin-license candidates #2295
Conversation
b4d1d5f
to
417cd67
Compare
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dushimsam , isn't the /repo/api/v1/license?kind=candidate endpoint already provide the required information?
No, i think it's different. So the the API for Candidate licenses already exists which is the one you are showing me. |
417cd67
to
1f32633
Compare
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
1f32633
to
a6c2d36
Compare
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
Signed-off-by: dushimsam <dushsam@gmail.com>
a6c2d36
to
c8907e3
Compare
c8907e3
to
9f4591f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good.
Tested, working as expected.
9f4591f
to
5b27e89
Compare
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
5b27e89
to
14723b5
Compare
Signed-off-by: dushimsam dushsam@gmail.com
Description
An endpoint to fetch the list of license candidates.
Changes
LicenseController
.AdminLicenseCandidate.php
to be reusable by the outside callers.index.php
) by adding a new routeGET
/license/candidates
.openapi.yaml
file to introduce a new API.How to test
Make a GET request on the end point accessed at "/license/candidates"
Example
Related Issue:
Fixes #2293
cc: @shaheemazmalmmd @GMishx