Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(API): get admin-license candidates #2295

Merged
merged 2 commits into from Feb 28, 2023

Conversation

dushimsam
Copy link
Contributor

@dushimsam dushimsam commented Aug 17, 2022

Signed-off-by: dushimsam dushsam@gmail.com

Description

An endpoint to fetch the list of license candidates.

Changes

  1. Added a new controller file and the function to handle the logic in LicenseController.
  2. Updated the file AdminLicenseCandidate.php to be reusable by the outside callers.
  3. Updated the main file(index.php) by adding a new route GET /license/candidates.
  4. Updated the openapi.yaml file to introduce a new API.

How to test

Make a GET request on the end point accessed at "/license/candidates"

Example

license_candidates

Related Issue:

Fixes #2293

cc: @shaheemazmalmmd @GMishx

@dushimsam dushimsam force-pushed the dushimsam/feat/get-candidates branch from b4d1d5f to 417cd67 Compare August 18, 2022 03:46
@shaheemazmalmmd shaheemazmalmmd added needs code review needs test GSoC-22 Label to tag issues and pull request for GSOC 2022 activities labels Aug 19, 2022
@dushimsam dushimsam changed the title feat(API): get license candidates feat(API): get admin-license candidates Aug 22, 2022
@github-actions github-actions bot added the has merge conflicts PR to be rebased label Aug 24, 2022
@github-actions
Copy link

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dushimsam , isn't the /repo/api/v1/license?kind=candidate endpoint already provide the required information?

@dushimsam
Copy link
Contributor Author

@dushimsam , isn't the /repo/api/v1/license?kind=candidate endpoint already provide the required information?

No, i think it's different.
We have Admin License candidates
image

and Candidate Licenses
image

So the the API for Candidate licenses already exists which is the one you are showing me.
What I did instead it's to add the other API for Admin License candidates.

@github-actions github-actions bot added has merge conflicts PR to be rebased and removed has merge conflicts PR to be rebased labels Sep 4, 2022
@github-actions
Copy link

github-actions bot commented Sep 5, 2022

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Sep 5, 2022
@GMishx GMishx added this to the 4.3.0 milestone Nov 9, 2022
@github-actions github-actions bot added the has merge conflicts PR to be rebased label Jan 19, 2023
@github-actions
Copy link

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

Signed-off-by: dushimsam <dushsam@gmail.com>
@GMishx GMishx force-pushed the dushimsam/feat/get-candidates branch from a6c2d36 to c8907e3 Compare February 28, 2023 08:15
@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Feb 28, 2023
@GMishx GMishx force-pushed the dushimsam/feat/get-candidates branch from c8907e3 to 9f4591f Compare February 28, 2023 08:17
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.
Tested, working as expected.

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
@GMishx GMishx force-pushed the dushimsam/feat/get-candidates branch from 5b27e89 to 14723b5 Compare February 28, 2023 08:47
@GMishx GMishx merged commit d2f676d into fossology:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC-22 Label to tag issues and pull request for GSOC 2022 activities ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

list license candidates via REST API
3 participants