feat(API): delete admin-license candidate #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaheemazmalmmd
added
needs code review
needs test
GSoC-22
|
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
dushimsam
force-pushed
the
dushimsam/feat/delete-license-candidate
branch
from
9c8381d
to
e2966d8
Compare
dushimsam
force-pushed
the
dushimsam/feat/delete-license-candidate
branch
2 times, most recently
from
e0d2b9e
to
5dc7231
Compare
|
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
GMishx
force-pushed
the
dushimsam/feat/delete-license-candidate
branch
from
5dc7231
to
d91acd0
Compare
GMishx
force-pushed
the
dushimsam/feat/delete-license-candidate
branch
from
d91acd0
to
22f9e48
Compare
GMishx
approved these changes
Feb 28, 2023
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
GMishx
force-pushed
the
dushimsam/feat/delete-license-candidate
branch
from
22f9e48
to
644879d
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dushimsam dushsam@gmail.com
Description
An endpoint to delete admin-license candidate.
Changes
LicenseController.AdminLicenseCandidate.phpto be reusable by the outside callers.index.php) by adding a new routeDELETE/license/candidates/{id}.openapi.yamlfile to introduce a new API.How to test
Make a DELETE request on the endpoint accessed at "/license/candidates/{id}"
Example
1. FIRST CASE
In this case, the Admin-license-candidate exists, and the license-candidate will be deleted successfully.
2. SECOND CASE
In this case, the Admin-license-candidate doesn't exist, so 404 error will be returned instead.
3. THIRD CASE
The request is not coming from the Admin.
This request can only be run by the admin , else the request will fail returning 400 ERROR.
Related Issue:
Fixes #2297
cc: @shaheemazmalmmd @GMishx