feat(api): get the contents of the file #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dushimsam
force-pushed
the
license-file-view
branch
2 times, most recently
from
7ea66b9
to
7df86aa
Compare
dushimsam
force-pushed
the
license-file-view
branch
4 times, most recently
from
0c30588
to
07253b2
Compare
GMishx
reviewed
Jun 9, 2023
dushimsam
force-pushed
the
license-file-view
branch
from
07253b2
to
ca95841
Compare
GMishx
added
the
GSOC-23
GMishx
requested changes
Jun 22, 2023
dushimsam
force-pushed
the
license-file-view
branch
2 times, most recently
from
92365bd
to
2a56b10
Compare
GMishx
approved these changes
Jun 28, 2023
|
Hey @dushimsam , please use this patch file to fix the test cases. |
|
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
dushimsam
force-pushed
the
license-file-view
branch
from
2a56b10
to
67fc402
Compare
Thank you so much, dear @GMishx, it worked 👍. |
Signed-off-by: dushimsam <dushsam@gmail.com>
dushimsam
force-pushed
the
license-file-view
branch
from
67fc402
to
55b06cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the API to retrieve the contents of a specific file.
Changes
UploadControllerto handle the logic.index.php) by adding a new routeGET/uploads/{id}/item/{itemId}/view.openapi.yamlfile to introduce a new API.How to test
Make a GET request on the endpoint:
/uploads/{id}/item/{itemId}/viewScreenshots
Related Issue:
Fixes #2454
cc: @shaheemazmalmmd @GMishx