-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): set the clearing decision for a particular item #2460
Conversation
3bf0fb2
to
290a5b6
Compare
7e750cd
to
4a84f82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions.
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
4a84f82
to
396d4be
Compare
396d4be
to
54d9d9a
Compare
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor change needed.
Signed-off-by: dushimsam <dushsam@gmail.com>
54d9d9a
to
f34019c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, working as expected.
Description
Added the API to set the clearing decision for a particular item.
Changes
uploadTree
for managing different actions on a particular items and with it's corresponding classUploadTreeController
.UploadTreeController
for setting the clearing decision for a particular item.index.php
) by adding a new routePUT
/uploadtree/{id}/clearing-decision
.openapi.yaml
file to write the new API's documentation.How to test
Make a PUT request on the endpoint:
/uploadtree/{id}/clearing-decision
, with header variablesdecisionType
&globalDecision
Screenshots
For a successful Request
When the uploadtree id is not FOUND
When the clearing decision type is NOT FOUND
When globalDecision value is not a boolean
Related Issue:
Fixes #2459
cc: @shaheemazmalmmd @GMishx