feat(api): Remove a particular main license from an upload #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dushimsam
force-pushed
the
remove-main-license
branch
2 times, most recently
from
7b648cc
to
7c1ca0f
Compare
GMishx
added
the
GSOC-23
GMishx
requested changes
Jun 22, 2023
| @@ -837,4 +837,38 @@ public function getGroupsWithPermissions($request, $response, $args) | |||
| $res["permGroups"] = $finalPermGroups; | |||
| return $response->withJson($res, 200); | |||
| } | |||
|
|
|||
| //remove main license | |||
| /*** | |||
dushimsam
force-pushed
the
remove-main-license
branch
2 times, most recently
from
17eeaf7
to
6c28191
Compare
GMishx
requested changes
Jun 28, 2023
|
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
dushimsam
force-pushed
the
remove-main-license
branch
from
6c28191
to
418da08
Compare
dushimsam
force-pushed
the
remove-main-license
branch
from
418da08
to
ab4bace
Compare
GMishx
requested changes
Jun 30, 2023
dushimsam
force-pushed
the
remove-main-license
branch
from
ab4bace
to
e8dbbba
Compare
dushimsam
force-pushed
the
remove-main-license
branch
from
e8dbbba
to
b8a3590
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the API to delete a specific main license from an upload.
Changes
UploadControllerto handle the logic.index.php) by adding a new routeDELETE/uploads/{id}/licenses/{licenseId}/main.openapi.yamlfile to introduce a new API.How to test
Make a DELETE request on the endpoint:
/uploads/{id}/licenses/{licenseId}/main.Screenshots
Related Issue:
Fixes #2459
cc: @shaheemazmalmmd @GMishx