Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): get main licenses assigned on an upload #2465

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

dushimsam
Copy link
Contributor

@dushimsam dushimsam commented Jun 13, 2023

Description

Added the API to get a list of the main licenses assigned on an upload.

Changes

  1. Added a new method in UploadController to handle the logic.
  2. Updated the main file(index.php) by adding a new route GET /uploads/{id}/licenses/main.
  3. Updated the openapi.yaml file to introduce a new API.

How to test

Make a GET request on the endpoint: /uploads/{id}/licenses/main.

Screenshots

image

Related Issue:

Fixes #2459

cc: @shaheemazmalmmd @GMishx

@GMishx GMishx added needs code review needs test GSOC-23 Label to tag pull request which are part of the GSOC 2023 labels Jun 22, 2023
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change needed.

src/www/ui/api/documentation/openapi.yaml Outdated Show resolved Hide resolved
Signed-off-by: dushimsam <dushsam@gmail.com>
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@GMishx GMishx added ready and removed needs test labels Jun 28, 2023
@GMishx GMishx merged commit 6507033 into fossology:master Jun 28, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSOC-23 Label to tag pull request which are part of the GSOC 2023 ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License File View - Details
2 participants