-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): get list of license decisions for an item #2470
Conversation
5651870
to
3d8a3e2
Compare
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
3d8a3e2
to
17466e2
Compare
17466e2
to
539b4aa
Compare
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
Also for clarification, what is the id 3 here? |
The response is a list of the licenses, obviously the "id" property should the license's id. |
98b68d9
to
3a780be
Compare
Hello @GMishx Hope this solves the issue, let me know how it looks 😉 |
3a780be
to
b8b18cd
Compare
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes required
Tested, working as expected. |
b8b18cd
to
13191ce
Compare
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
13191ce
to
e5a7418
Compare
Signed-off-by: dushimsam <dushsam@gmail.com>
e5a7418
to
309dd70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good.
Description
Added the API to retrieve a list of license decisions for a particular item.
Changes
UploadTreeController
to handle the logic.UploadTreeController
for adding the new license on the selected item.index.php
) by adding a new routeGET
/uploads/{id}/items/{itemId}/licenses
.openapi.yaml
file to write the new API's documentation.How to test
Make a GET request on the endpoint:
/uploads/{id}/items/{itemId}/licenses
,Screenshots
Related Issue:
Fixes #2459
cc: @shaheemazmalmmd @GMishx