feat(api): update clearing info (TEXT, ACK & COMMENT) for a license #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dushimsam
changed the title
dushimsam
force-pushed
the
set-clearing-info
branch
from
108e799
to
7375ec4
Compare
dushimsam
force-pushed
the
set-clearing-info
branch
from
7375ec4
to
858dc33
Compare
GMishx
added
needs code review
needs test
GSOC-23
|
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
|
Closed in favor of #2509 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the API to update the clearing info (LICENSE TEXT, ACKNOWLEDGMENT, OR COMMENT) for a specific license decision.
Changes
UploadTreeControllerto handle the logic.UploadTreeControllerfor adding the new license on the selected item.index.php) by adding a new routePUT/uploads/{id}/items/{itemId}/licenses/{licenseId}/clearing-info.openapi.yamlfile to write the new API's documentation.How to test
Make a PUT request on the endpoint:
/uploads/{id}/items/{itemId}/licenses/{licenseId}/clearing-info,Screenshots
Related Issue:
Fixes #2459
cc: @shaheemazmalmmd @GMishx