-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): API for updating File copyright content #2479
Conversation
386ef3c
to
fba7a64
Compare
119f691
to
7a89990
Compare
7a89990
to
f82f023
Compare
Would recommend to put the actual body content in the screenshots rather than just showing the response :-) |
Sure sir, I will be updating the PR accordingly soon. |
ee89741
to
5959b68
Compare
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
b2298ac
to
5959b68
Compare
5959b68
to
a4abe4d
Compare
a4abe4d
to
3344602
Compare
Made the requested changes sir, Please do have a look |
3344602
to
4fdf36c
Compare
4fdf36c
to
45258ea
Compare
45258ea
to
3752dd9
Compare
Made the requested changes sir. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, working as expected.
@soham4abc , kindly rebase for merge. |
4c7d8d4
to
3b0eb9c
Compare
I'm rebasing the branch |
3b0eb9c
to
ee2b2f7
Compare
@GMishx Please do have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good.
Description
API to update File copyright is added in this PR
How to test
Send a
PUT
request to the endpoint/file/upload/{Upload_id}/item/{Item_id}/copyright/{Copyright_hash}
with a body :
##Screenshots:
closes #2468
Please consider using the closing keyword if the pull request is proposed to
fix an issue already created in the repository
(https://help.github.com/articles/closing-issues-using-keywords/)