Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): API for updating File copyright content #2479

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

soham4abc
Copy link
Contributor

@soham4abc soham4abc commented Jun 18, 2023

Description

API to update File copyright is added in this PR

How to test

Send a PUT request to the endpoint /file/upload/{Upload_id}/item/{Item_id}/copyright/{Copyright_hash}

with a body :

{
  "content": "New Test copyright text"
}

##Screenshots:

  • Before sending the API request:

Screenshot from 2023-06-18 18-09-36

  • The API Request:

Screenshot from 2023-06-18 18-09-50

  • After the API request:

Screenshot from 2023-06-18 18-10-01

closes #2468

Please consider using the closing keyword if the pull request is proposed to
fix an issue already created in the repository
(https://help.github.com/articles/closing-issues-using-keywords/)

@soham4abc soham4abc force-pushed the api/UpdateFileCopyrights branch 2 times, most recently from 386ef3c to fba7a64 Compare June 21, 2023 05:22
@GMishx GMishx added needs code review needs test GSOC-23 Label to tag pull request which are part of the GSOC 2023 labels Jun 22, 2023
@soham4abc soham4abc force-pushed the api/UpdateFileCopyrights branch 2 times, most recently from 119f691 to 7a89990 Compare June 23, 2023 05:34
@soham4abc soham4abc mentioned this pull request Jun 24, 2023
@GMishx
Copy link
Member

GMishx commented Jun 29, 2023

Would recommend to put the actual body content in the screenshots rather than just showing the response :-)

src/www/ui/api/Controllers/CopyrightController.php Outdated Show resolved Hide resolved
src/www/ui/api/Controllers/CopyrightController.php Outdated Show resolved Hide resolved
src/www/ui/api/Controllers/CopyrightController.php Outdated Show resolved Hide resolved
src/www/ui/api/Controllers/CopyrightController.php Outdated Show resolved Hide resolved
src/www/ui/api/Controllers/CopyrightController.php Outdated Show resolved Hide resolved
src/www/ui/api/Controllers/CopyrightController.php Outdated Show resolved Hide resolved
src/www/ui/api/Controllers/CopyrightController.php Outdated Show resolved Hide resolved
src/www/ui/api/documentation/openapi.yaml Outdated Show resolved Hide resolved
src/www/ui/api/documentation/openapi.yaml Outdated Show resolved Hide resolved
@soham4abc
Copy link
Contributor Author

Would recommend to put the actual body content in the screenshots rather than just showing the response :-)

Sure sir, I will be updating the PR accordingly soon.

@soham4abc soham4abc force-pushed the api/UpdateFileCopyrights branch 3 times, most recently from ee89741 to 5959b68 Compare June 30, 2023 04:49
@github-actions github-actions bot added the has merge conflicts PR to be rebased label Jun 30, 2023
@github-actions
Copy link

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

@soham4abc soham4abc force-pushed the api/UpdateFileCopyrights branch 2 times, most recently from b2298ac to 5959b68 Compare June 30, 2023 05:53
src/www/ui/api/Controllers/CopyrightController.php Outdated Show resolved Hide resolved
src/www/ui/api/Controllers/CopyrightController.php Outdated Show resolved Hide resolved
src/www/ui/api/documentation/openapi.yaml Outdated Show resolved Hide resolved
@soham4abc
Copy link
Contributor Author

Made the requested changes sir,

Please do have a look

@GMishx

@soham4abc
Copy link
Contributor Author

Made the requested changes sir.
Please do have a look @GMishx

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@GMishx GMishx added ready and removed needs test labels Jul 5, 2023
@GMishx
Copy link
Member

GMishx commented Jul 5, 2023

@soham4abc , kindly rebase for merge.

@soham4abc
Copy link
Contributor Author

I'm rebasing the branch

@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Jul 5, 2023
@soham4abc
Copy link
Contributor Author

@GMishx Please do have a look

@soham4abc soham4abc requested a review from GMishx July 5, 2023 07:01
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@GMishx GMishx merged commit 3a8b583 into fossology:master Jul 5, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSOC-23 Label to tag pull request which are part of the GSOC 2023 ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copyright File-view
2 participants