-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): API to handle three filters to get prev & next item #2480
Conversation
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
Would've been nice if you would have posted the postman screenshots with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes.
Tested, working as expected. |
Eish, I messed up 🥴 |
42a1fa5
to
5874ac2
Compare
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
5874ac2
to
d3c986e
Compare
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
1 similar comment
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good.
@dushimsam , please rebase for merge. |
d3c986e
to
e6b086f
Compare
Done |
Description
Added the API to get the what should be the next and the previous item, given the current Item Id.
Changes
UploadTreeController
to handle the logic.index.php
) by adding a new routeGET
/uploads/{id}/items/{itemId}/prev-next
.openapi.yaml
file to write the new API's documentation.How to test
Make a GET request on the endpoint:
GET
/uploads/{id}/items/{itemId}/prev-next
.Screenshots
1. Without any filter
2. WithLicenses filter
3. noClearing Filter
Related Issue:
Fixes #2472
cc: @shaheemazmalmmd @GMishx