Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): API to return total number of copyrights for a file #2488

Merged
merged 1 commit into from
Jul 11, 2023
Merged

feat(api): API to return total number of copyrights for a file #2488

merged 1 commit into from
Jul 11, 2023

Conversation

soham4abc
Copy link
Contributor

@soham4abc soham4abc commented Jun 21, 2023 •
edited by gitpod-io bot

Description

This API returns the total number of copyrights for a UploadTree

How to test

Send a GET request to /file/upload/{UploadId}/item/{ItemId}/totalcopyrights

##Screenshots
Screenshot from 2023-06-21 22-47-51

Fixes #2468

@shaheemazmalmmd Please do have a look as this was requested on priority basis.

@soham4abc soham4abc mentioned this pull request Jun 22, 2023
Closed
@GMishx GMishx added needs code review needs test GSOC-23 Label to tag pull request which are part of the GSOC 2023 labels Jun 22, 2023
@soham4abc soham4abc mentioned this pull request Jun 24, 2023
Open
@github-actions github-actions bot added the has merge conflicts PR to be rebased label Jun 29, 2023
@github-actions
Copy link

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Jun 29, 2023
@github-actions github-actions bot added the has merge conflicts PR to be rebased label Jun 29, 2023
@github-actions
Copy link

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Jun 29, 2023
@soham4abc soham4abc force-pushed the api/getTotalCopyrights branch 2 times, most recently from 68585b4 to 14d04c8 Compare June 29, 2023 06:23
@github-actions github-actions bot added has merge conflicts PR to be rebased labels Jul 5, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

1 similar comment
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

GMishx
GMishx requested changes Jul 5, 2023
View reviewed changes
src/www/ui/api/Controllers/CopyrightController.php Outdated Show resolved Hide resolved
src/www/ui/api/Controllers/CopyrightController.php Outdated Show resolved Hide resolved
src/www/ui/api/Controllers/CopyrightController.php Outdated Show resolved Hide resolved
src/www/ui/api/Controllers/CopyrightController.php Outdated Show resolved Hide resolved
src/www/ui/api/Controllers/CopyrightController.php Outdated Show resolved Hide resolved
src/www/ui/api/documentation/openapi.yaml Outdated Show resolved Hide resolved
src/www/ui/api/documentation/openapi.yaml Outdated Show resolved Hide resolved
@soham4abc soham4abc force-pushed the api/getTotalCopyrights branch 2 times, most recently from 1934497 to be9f280 Compare July 11, 2023 09:48
@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Jul 11, 2023
@soham4abc soham4abc force-pushed the api/getTotalCopyrights branch 2 times, most recently from 7f64343 to 016ef03 Compare July 11, 2023 09:53
@soham4abc
Copy link
Contributor Author

@GMishx I was planning to add query parameter to this endpoint so that we can actually get the number of total copyrights for both active and inactive types.

Should i go for it?

@GMishx
Copy link
Member

GMishx commented Jul 11, 2023

@GMishx I was planning to add query parameter to this endpoint so that we can actually get the number of total copyrights for both active and inactive types.

Should i go for it?

Yes @soham4abc , it will be a good feature.

@soham4abc
Copy link
Contributor Author

soham4abc commented Jul 11, 2023 •
edited

@GMishx I was planning to add query parameter to this endpoint so that we can actually get the number of total copyrights for both active and inactive types.
Should i go for it?

Yes @soham4abc , it will be a good feature.

Done as per request sir.

Please do have a look!

image

GMishx
GMishx approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

GMishx
GMishx approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@GMishx GMishx added ready and removed needs test labels Jul 11, 2023
@GMishx GMishx merged commit 69b586b into fossology:master Jul 11, 2023
14 checks passed
@GMishx GMishx mentioned this pull request Jul 28, 2023
Merged
@deveaud-m deveaud-m mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx approved these changes

Assignees
No one assigned
Labels
GSOC-23 Label to tag pull request which are part of the GSOC 2023 ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copyright File-view
2 participants
@soham4abc @GMishx