Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): get the license tree-view of the upload and item #2492

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

dushimsam
Copy link
Contributor

@dushimsam dushimsam commented Jun 26, 2023

Description

Added the API to get retrieve the rows that makes a tree-view from a specific upload and item.

Changes

  1. Added a new method in UploadTreeController to handle the logic.
  2. Updated the main file(index.php) by adding a new route GET /uploads/{id}/item/{itemId}/tree/view.
  3. Updated the openapi.yaml file to introduce a new API.

How to test

Make a GET request on the endpoint: /uploads/{id}/item/{itemId}/tree/view

Screenshots

UI View:
image

Corresponding API Object:

image

UI View:
image

Corresponding API Object:

image

Related Issue:

Fixes #2467

cc: @shaheemazmalmmd @GMishx

@dushimsam dushimsam force-pushed the get-tree-view branch 2 times, most recently from aa42b8a to d9f5241 Compare June 26, 2023 05:07
@GMishx GMishx added needs code review needs test GSOC-23 Label to tag pull request which are part of the GSOC 2023 labels Jun 26, 2023
@github-actions github-actions bot added the has merge conflicts PR to be rebased label Jun 29, 2023
@github-actions
Copy link

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase the branch as well.

src/www/ui/api/Controllers/UploadTreeController.php Outdated Show resolved Hide resolved
src/www/ui/api/documentation/openapi.yaml Outdated Show resolved Hide resolved
src/www/ui/api/documentation/openapi.yaml Outdated Show resolved Hide resolved
src/www/ui/api/documentation/openapi.yaml Show resolved Hide resolved
src/www/ui/api/documentation/openapi.yaml Outdated Show resolved Hide resolved
@dushimsam dushimsam force-pushed the get-tree-view branch 2 times, most recently from 705f58c to 19a1744 Compare July 13, 2023 10:46
@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Jul 13, 2023
@dushimsam
Copy link
Contributor Author

Done with updating the changes. Let me know anything else to modify.
@GMishx

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@GMishx GMishx added ready has merge conflicts PR to be rebased and removed needs test labels Jul 24, 2023
Signed-off-by: dushimsam <dushsam@gmail.com>
@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Jul 24, 2023
@GMishx GMishx merged commit 8401e33 into fossology:master Jul 26, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSOC-23 Label to tag pull request which are part of the GSOC 2023 ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License Browser - Scanner Licenses
2 participants