Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Get the clearing-progress info for an upload. #2494

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

dushimsam
Copy link
Contributor

@dushimsam dushimsam commented Jun 26, 2023

Description

Added the API to get retrieve the rows that makes a tree-view from a specific upload and item.

Changes

  1. Added a new method in UploadController to handle the logic.
  2. Updated the main file(index.php) by adding a new route GET /uploads/{id}/clearing/progress.
  3. Updated the openapi.yaml file to introduce a new API.

How to test

Make a GET request on the endpoint: /uploads/{id}/clearing/progress

Screenshots

UI View:
image

Corresponding API Object:

image

Related Issue:

Fixes #2459

cc: @shaheemazmalmmd @GMishx

@GMishx GMishx added needs code review needs test GSOC-23 Label to tag pull request which are part of the GSOC 2023 labels Jun 26, 2023
@github-actions github-actions bot added the has merge conflicts PR to be rebased label Jun 29, 2023
@github-actions
Copy link

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Please rebase the branch as well.

@github-actions github-actions bot added has merge conflicts PR to be rebased and removed has merge conflicts PR to be rebased labels Jul 6, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@GMishx GMishx added ready and removed needs test labels Jul 10, 2023
@GMishx
Copy link
Member

GMishx commented Jul 10, 2023

@dushimsam , looks like there are some white space at the end of line
https://github.com/fossology/fossology/actions/runs/5474170195/jobs/9968608806?pr=2494#step:4:207

Also, please use following patch to fix the test cases.
patch.txt

@GMishx
Copy link
Member

GMishx commented Jul 10, 2023

The PR is marked as ready. Please rebase for merge.

Signed-off-by: dushimsam <dushsam@gmail.com>
@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Jul 10, 2023
@dushimsam
Copy link
Contributor Author

The PR is marked as ready. Please rebase for merge.

Done rebasing

@GMishx GMishx merged commit ab9a422 into fossology:master Jul 10, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSOC-23 Label to tag pull request which are part of the GSOC 2023 ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License File View - Details
2 participants