Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): get a list of scanned licenses for an upload #2495

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

dushimsam
Copy link
Contributor

@dushimsam dushimsam commented Jun 26, 2023

Description

Added the API to retrieve a list of the scanned licenses for a given upload.

Changes

  1. Added a new method in UploadController to handle the logic.
  2. Updated the main file(index.php) by adding a new route GET /uploads/{id}/licenses/scanned.
  3. Updated the openapi.yaml file to introduce a new API.

How to test

Make a GET request on the endpoint: /uploads/{id}/licenses/scanned.

Screenshots

UI View:

image

API response:

image

Related Issue:

Fixes #2467

cc: @shaheemazmalmmd @GMishx

@GMishx GMishx added needs code review needs test GSOC-23 Label to tag pull request which are part of the GSOC 2023 labels Jun 26, 2023
@github-actions github-actions bot added the has merge conflicts PR to be rebased label Jun 29, 2023
@github-actions
Copy link

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

src/www/ui/api/documentation/openapi.yaml Outdated Show resolved Hide resolved
src/www/ui/api/documentation/openapi.yaml Outdated Show resolved Hide resolved
src/www/ui/api/documentation/openapi.yaml Outdated Show resolved Hide resolved
src/www/ui/api/documentation/openapi.yaml Outdated Show resolved Hide resolved
@github-actions github-actions bot added has merge conflicts PR to be rebased and removed has merge conflicts PR to be rebased labels Jul 7, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor change needed.

src/www/ui/api/Controllers/UploadController.php Outdated Show resolved Hide resolved
@dushimsam dushimsam force-pushed the get-scanned-licenses branch 2 times, most recently from 98d44bc to 5755f7a Compare July 24, 2023 16:01
@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Jul 24, 2023
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@GMishx GMishx added ready has merge conflicts PR to be rebased and removed needs test labels Jul 26, 2023
@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Jul 26, 2023
@GMishx
Copy link
Member

GMishx commented Jul 26, 2023

@GMishx
Copy link
Member

GMishx commented Jul 26, 2023

Sorry to disturb again but can you please rebase the branch for merging @dushimsam ?

@github-actions github-actions bot added the has merge conflicts PR to be rebased label Jul 26, 2023
@github-actions
Copy link

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

@dushimsam
Copy link
Contributor Author

Sorry to disturb again but can you please rebase the branch for merging @dushimsam ?

No worries @GMishx , let me do it

@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Jul 26, 2023
Signed-off-by: dushimsam <dushsam@gmail.com>
@GMishx GMishx merged commit bcc9274 into fossology:master Jul 28, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSOC-23 Label to tag pull request which are part of the GSOC 2023 ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License Browser - Scanner Licenses
2 participants