-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): get a list of scanned licenses for an upload #2495
Conversation
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
f5fdb65
to
43ab718
Compare
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor change needed.
98d44bc
to
5755f7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, working as expected.
5755f7a
to
092ee48
Compare
092ee48
to
6c40fd4
Compare
Sorry to disturb again but can you please rebase the branch for merging @dushimsam ? |
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
No worries @GMishx , let me do it |
6c40fd4
to
085c67d
Compare
Signed-off-by: dushimsam <dushsam@gmail.com>
085c67d
to
c755ff5
Compare
Description
Added the API to retrieve a list of the scanned licenses for a given upload.
Changes
UploadController
to handle the logic.index.php
) by adding a new routeGET
/uploads/{id}/licenses/scanned
.openapi.yaml
file to introduce a new API.How to test
Make a GET request on the endpoint:
/uploads/{id}/licenses/scanned
.Screenshots
UI View:
API response:
Related Issue:
Fixes #2467
cc: @shaheemazmalmmd @GMishx